Added service for TestPilot CI#229
Conversation
|
What's with the Talker change? I may handle this outside the pull request and leave that commit out. |
|
The Talker commit addresses an invalid encoding issue on 1.9.x, I assume you run everything on 1.8.7 so it's probably not an issue. |
|
Well, you're free to re-send that in another pull request. Someday I'd like to get this crap on 1.9. I can't remember what the blocker was though. I'd like to keep the pull requests small and focused to a single service if possible. Also, I had just merged another Talker pull, which broke your pull :) |
|
Which pull request was that? I'd like to know what they changed. As far as I can tell, the xmpp4r-simple-0.8.8 gem is not 1.9 compatible, it seems to contain syntax errors. Apart from that, I had all tests passing on 1.9 after patching that, and the talker service. |
|
#227 is the pull I'm referring to. Ah yea, that sounds right. Our current scaling issues with Services deal with slow/down 3rd party services more than CPU time, so an upgrade to 1.9 isn't that high of a priority. |
I've added a service to trigger builds on TestPilot CI.
Contents:
Tests pass on Ruby 1.8.7 as seen here http://testpilot.me/ivan/github-services/tasks/968