Skip to content
This repository was archived by the owner on Jan 31, 2019. It is now read-only.

Added service for TestPilot CI#229

Closed
ivanvanderbyl wants to merge 7 commits intogithub:masterfrom
ivanvanderbyl:master
Closed

Added service for TestPilot CI#229
ivanvanderbyl wants to merge 7 commits intogithub:masterfrom
ivanvanderbyl:master

Conversation

@ivanvanderbyl
Copy link
Contributor

I've added a service to trigger builds on TestPilot CI.

Contents:

  • service
  • tests
  • docs

Tests pass on Ruby 1.8.7 as seen here http://testpilot.me/ivan/github-services/tasks/968

@technoweenie
Copy link
Contributor

What's with the Talker change? I may handle this outside the pull request and leave that commit out.

@technoweenie technoweenie mentioned this pull request Jan 24, 2012
@ivanvanderbyl
Copy link
Contributor Author

The Talker commit addresses an invalid encoding issue on 1.9.x, I assume you run everything on 1.8.7 so it's probably not an issue.

@technoweenie
Copy link
Contributor

Well, you're free to re-send that in another pull request. Someday I'd like to get this crap on 1.9. I can't remember what the blocker was though. I'd like to keep the pull requests small and focused to a single service if possible. Also, I had just merged another Talker pull, which broke your pull :)

@ivanvanderbyl
Copy link
Contributor Author

Which pull request was that? I'd like to know what they changed.

As far as I can tell, the xmpp4r-simple-0.8.8 gem is not 1.9 compatible, it seems to contain syntax errors. Apart from that, I had all tests passing on 1.9 after patching that, and the talker service.

@technoweenie
Copy link
Contributor

#227 is the pull I'm referring to.

Ah yea, that sounds right. Our current scaling issues with Services deal with slow/down 3rd party services more than CPU time, so an upgrade to 1.9 isn't that high of a priority.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants