util/mime: pass invalidSubtypeIndex instead of trimmedSubtype to error#49711
Closed
gaurishhs wants to merge 1 commit intonodejs:mainfrom
gaurishhs:gaurishhs/fix-mime
Closed
util/mime: pass invalidSubtypeIndex instead of trimmedSubtype to error#49711gaurishhs wants to merge 1 commit intonodejs:mainfrom gaurishhs:gaurishhs/fix-mime
gaurishhs wants to merge 1 commit intonodejs:mainfrom
gaurishhs:gaurishhs/fix-mime
Conversation
jasnell
approved these changes
Oct 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Oct 29, 2023
Contributor
Author
|
hi, any updates? |
Collaborator
This was referenced Nov 12, 2023
deokjinkim
approved these changes
Dec 23, 2023
Contributor
|
@gaurishhs Could you modify commit title according to guide(https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines)? |
Contributor
Author
|
@deokjinkim @jasnell I was having conflicts on my local git while rebasing. I have opened a new PR to make things good. Please look into #51264 I'm sorry for the mess i created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error
ERR_INVALID_MIME_SYNTAXexpects the invalid index which wasn't being passed.