Skip to content

util: fix wrong argument of ERR_INVALID_MIME_SYNTAX#50577

Closed
deokjinkim wants to merge 1 commit intonodejs:mainfrom
deokjinkim:231106_fix_argument_mime
Closed

util: fix wrong argument of ERR_INVALID_MIME_SYNTAX#50577
deokjinkim wants to merge 1 commit intonodejs:mainfrom
deokjinkim:231106_fix_argument_mime

Conversation

@deokjinkim
Copy link
Contributor

@deokjinkim deokjinkim commented Nov 6, 2023

Third argument of ERR_INVALID_MIME_SYNTAX is invalid index (not string).

node/lib/internal/errors.js

Lines 1419 to 1422 in cde3296

E('ERR_INVALID_MIME_SYNTAX', (production, str, invalidIndex) => {
const msg = invalidIndex !== -1 ? ` at ${invalidIndex}` : '';
return `The MIME syntax for a ${production} in "${str}" is invalid` + msg;
}, TypeError);

When I tested with below example,

const { MIMEType } = require('node:util');
const myMIME = new MIMEType('text/javascript,');

Before

node:internal/mime:73
    throw new ERR_INVALID_MIME_SYNTAX('subtype', str, trimmedSubtype);
    ^

TypeError [ERR_INVALID_MIME_SYNTAX]: The MIME syntax for a subtype in "text/javascript," is invalid at javascript,
    at parseTypeAndSubtype (node:internal/mime:73:11)
    at new MIMEType (node:internal/mime:332:18)

After

node:internal/mime:73
    throw new ERR_INVALID_MIME_SYNTAX('subtype', str, invalidSubtypeIndex);
    ^

TypeError [ERR_INVALID_MIME_SYNTAX]: The MIME syntax for a subtype in "text/javascript," is invalid at 10
    at parseTypeAndSubtype (node:internal/mime:73:11)
    at new MIMEType (node:internal/mime:332:18)

@deokjinkim
util: fix wrong argument of ERR_INVALID_MIME_SYNTAX
e7b5c99 
Third argument of ERR_INVALID_MIME_SYNTAX is invalid index
(not string).
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 6, 2023
@deokjinkim deokjinkim marked this pull request as ready for review November 6, 2023 13:40
@deokjinkim deokjinkim requested a review from bmeck November 6, 2023 13:46
@deokjinkim deokjinkim added the review wanted PRs that need reviews. label Nov 10, 2023
@marco-ippolito
Copy link
Member

marco-ippolito commented Dec 21, 2023

maybe we can improve the error message since The MIME syntax for a subtype in "text/javascript," is invalid at 10 is not very informative

@deokjinkim
Copy link
Contributor Author

deokjinkim commented Dec 23, 2023

Close this PR because duplicated to #49711.

@deokjinkim deokjinkim closed this Dec 23, 2023
@deokjinkim deokjinkim removed the review wanted PRs that need reviews. label Dec 23, 2023
@gaurishhs gaurishhs mentioned this pull request Dec 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmeck bmeck Awaiting requested review from bmeck

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deokjinkim @marco-ippolito @nodejs-github-bot

Comments