Closed
Conversation
|
Thank you for contributing to openstack/python-openstackclient! openstack/python-openstackclient uses Gerrit for code review. Please visit http://wiki.openstack.org/GerritWorkflow and follow the |
openstack-gerrit
pushed a commit
that referenced
this pull request
Jun 12, 2018
This is a squash of two commits that need to be merged together in order to get all tests to pass: Commit message #1: Use Zuul v3 fetch-subunit-output We have consolidated the fetch output roles into one fetch-subunit-output, replace useage of old roles with new one. Original change-id: Iae2892d9b4cd870a11579434edc9ee66bd16798c (cherry picked from commit 0a2ee90) Commit message #2: Fix sphinx-docs job for stable branch build-openstack-sphinx-docs jobs fail on stable branches because the new pip version 10 changed a Warning into an Error: When calling "pip install" without any package name, the command now fails. tox_install.sh is being called during docs job without any package passed to pip. Note that this only affects stable/pike and older, so there is no patch in master to cherry-pick this from. Newer branches use a different way to set up the tox environment. Depends-On: https://review.openstack.org/573665 Change-Id: I35e9ede7103031ea3ea45e35d743e63059fb8d0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes Volume region selection the same as Compute was fixed in https://bugs.launchpad.net/python-openstackclient/+bug/1405416
I do not have access to
identityorobjectstores, so I can not verify that they are affected, but if they are, the same patch should apply to theirclient.py.