Skip to content

Volume client honor set region#2

Closed
erichelgeson wants to merge 1 commit intoopenstack:masterfrom
erichelgeson:master
Closed

Volume client honor set region#2
erichelgeson wants to merge 1 commit intoopenstack:masterfrom
erichelgeson:master

Conversation

@erichelgeson
Copy link
Contributor

This patch fixes Volume region selection the same as Compute was fixed in https://bugs.launchpad.net/python-openstackclient/+bug/1405416

I do not have access to identity or object stores, so I can not verify that they are affected, but if they are, the same patch should apply to their client.py.

diff --git a/openstackclient/identity/client.py b/openstackclient/identity/client.py
index daf24e1..d10d046 100644
--- a/openstackclient/identity/client.py
+++ b/openstackclient/identity/client.py
@@ -49,6 +49,7 @@ def make_client(instance):
     LOG.debug('Using auth plugin: %s' % instance._auth_plugin)
     client = identity_client(
         session=instance.session,
+        region_name=instance._region_name,
     )

     return client
diff --git a/openstackclient/object/client.py b/openstackclient/object/client.py
index beb7c04..d967cf4 100644
--- a/openstackclient/object/client.py
+++ b/openstackclient/object/client.py
@@ -42,6 +42,7 @@ def make_client(instance):
         session=instance.session,
         service_type='object-store',
         endpoint=endpoint,
+        region_name=instance._region_name,
     )
     return client

@openstack-gerrit
Copy link

Thank you for contributing to openstack/python-openstackclient!

openstack/python-openstackclient uses Gerrit for code review.

Please visit http://wiki.openstack.org/GerritWorkflow and follow the
instructions there to upload your change to Gerrit.

openstack-gerrit pushed a commit that referenced this pull request Jun 12, 2018
This is a squash of two commits that need to be merged together in order
to get all tests to pass:

Commit message #1:

Use Zuul v3 fetch-subunit-output

We have consolidated the fetch output roles into one
fetch-subunit-output, replace useage of old roles with new one.

Original change-id: Iae2892d9b4cd870a11579434edc9ee66bd16798c
(cherry picked from commit 0a2ee90)

Commit message #2:

Fix sphinx-docs job for stable branch

build-openstack-sphinx-docs jobs fail on stable branches because the
new pip version 10 changed a Warning into an Error: When calling
"pip install" without any package name, the command now fails.
tox_install.sh is being called during docs job without any package
passed to pip.

Note that this only affects stable/pike and older, so there is no patch
in master to cherry-pick this from. Newer branches use a different way
to set up the tox environment.

Depends-On: https://review.openstack.org/573665
Change-Id: I35e9ede7103031ea3ea45e35d743e63059fb8d0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants