All commit authors signed the Contributor License Agreement.

This fix in add_datetime_timedelta() also fixes the same type confusion crash in datetime.utctimetuple(), since it also calls add_datetime_timedelta() internally. However, there is no test coverage for that case.

Could you add a test for utctimetuple as well? Something like:

def test_utctimetuple_subclass_new_returns_non_datetime(self):
    call_count = 0

    class EvilDatetime(self.theclass):
        def __new__(cls, *args, **kwargs):
            nonlocal call_count
            call_count += 1
            if call_count > 1:
                return bytearray(b'\x00' * 200)
            return super().__new__(cls, *args, **kwargs)

    class SimpleTZ(tzinfo):
        def utcoffset(self, dt): return timedelta(hours=5)
        def dst(self, dt):       return timedelta(0)
        def tzname(self, dt):    return "Test"

    tz = SimpleTZ()
    dt = EvilDatetime(2000, 6, 15, 12, 0, 0, tzinfo=tz)
    with self.assertRaises(TypeError):
        dt.utctimetuple()

This fix in add_datetime_timedelta() also fixes the same type confusion crash in datetime.utctimetuple(), since it also calls add_datetime_timedelta() internally. However, there is no test coverage for that case.

Could you add a test for utctimetuple as well? Something like:

def test_utctimetuple_subclass_new_returns_non_datetime(self):
    call_count = 0

    class EvilDatetime(self.theclass):
        def __new__(cls, *args, **kwargs):
            nonlocal call_count
            call_count += 1
            if call_count > 1:
                return bytearray(b'\x00' * 200)
            return super().__new__(cls, *args, **kwargs)

    class SimpleTZ(tzinfo):
        def utcoffset(self, dt): return timedelta(hours=5)
        def dst(self, dt):       return timedelta(0)
        def tzname(self, dt):    return "Test"

    tz = SimpleTZ()
    dt = EvilDatetime(2000, 6, 15, 12, 0, 0, tzinfo=tz)
    with self.assertRaises(TypeError):
        dt.utctimetuple()

@raminfp Thanks for good test, i added this to my PR

It was great, but I think this utctimetuple should also be mentioned in the NEWS.

It was great, but I think this utctimetuple should also be mentioned in the NEWS.

@raminfp Done!

@StanFromIreland Hi, could you please review this PR and merge it if everything looks good?

Please don't force push, see the devguide for more information.

Also, please note that this is a volunteer project, I try to review within ~48 hours, please don't ping me (unless it has been a long time, i.e. a month, since my review).