Skip to content

gh-145260: fix(importlib.resources.simple): Make ResourceContainer and ResourceH…#145263

Open
zetzschest wants to merge 4 commits intopython:mainfrom
zetzschest:fix/importlib_simple_resource_traversable
Open

gh-145260: fix(importlib.resources.simple): Make ResourceContainer and ResourceH…#145263
zetzschest wants to merge 4 commits intopython:mainfrom
zetzschest:fix/importlib_simple_resource_traversable

Conversation

@zetzschest
Copy link

@zetzschest zetzschest commented Feb 26, 2026 •
edited by bedevere-app bot
Loading

Problem

ResourceContainer and ResourceHandle cannot be instantiated because Traversable now requires name as an abstract property. Also, iterdir() accesses self.reader.resources without calling it, and ResourceHandle.joinpath has a signature mismatch.

Reproducer

from importlib.resources.simple import ResourceContainer, SimpleReader
import io

class R(SimpleReader):
    @property
    def package(self): return 'x'
    def children(self): return []
    def resources(self): return []
    def open_binary(self, r): return io.BytesIO(b'')

ResourceContainer(R())  # TypeError

Fix

  • Add name property to ResourceContainer and ResourceHandle
  • Add iterdir to ResourceHandle
  • Fix self.reader.resources → self.reader.resources() in ResourceContainer.iterdir()
  • Fix ResourceHandle.joinpath to accept *descendants

@zetzschest
pythongh-145260: Fix importlib.resources.simple ResourceContainer and…
cc54d86 
… ResourceHandle

ResourceContainer and ResourceHandle could not be instantiated because
Traversable now requires name as an abstract property. Additionally,
ResourceContainer.iterdir() accessed self.reader.resources without
calling it, and ResourceHandle.joinpath had a signature mismatch.

- Add name property to ResourceContainer
- Fix self.reader.resources -> self.reader.resources() call
- Add iterdir() method to ResourceHandle
- Fix ResourceHandle.joinpath to accept *descendants
@bedevere-app bedevere-app bot mentioned this pull request Feb 26, 2026
Open
@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@zetzschest zetzschest marked this pull request as ready for review February 26, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zetzschest