Skip to content

gh-145260: fix ResourceContainer/ResourceHandle for Traversable changes #145263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zetzschest wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −2
Open

gh-145260: fix ResourceContainer/ResourceHandle for Traversable changes #145263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c2aa98
gh-145260: Fix importlib.resources.simple ResourceContainer and Resou…
zetzschest Feb 26, 2026
901c776
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 26, 2026
46a00fc
Fix NEWS entry: use plain markup for undocumented classes
zetzschest Feb 26, 2026
efdc545
Fix NEWS entry: use plain markup for undocumented module
zetzschest Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Lib/importlib/resources/simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,18 @@ class ResourceContainer(Traversable):
def __init__(self, reader: SimpleReader):
self.reader = reader

@property
def name(self):
return self.reader.name

def is_dir(self):
return True

def is_file(self):
return False

def iterdir(self):
files = (ResourceHandle(self, name) for name in self.reader.resources)
files = (ResourceHandle(self, name) for name in self.reader.resources())
dirs = map(ResourceContainer, self.reader.children())
return itertools.chain(files, dirs)

Expand All @@ -85,13 +89,18 @@ def is_file(self):
def is_dir(self):
return False

def iterdir(self):
return iter([])

def open(self, mode='r', *args, **kwargs):
stream = self.parent.reader.open_binary(self.name)
if 'b' not in mode:
stream = io.TextIOWrapper(stream, *args, **kwargs)
return stream

def joinpath(self, name):
def joinpath(self, *descendants):
if not descendants:
return self
raise RuntimeError("Cannot traverse into a resource")


Expand Down
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Library/2026-02-26-15-46-50.gh-issue-145260.wmT5hp.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Fix ``ResourceContainer`` and ``ResourceHandle`` in
``importlib.resources.simple`` being uninstantiable due to missing ``name``
property required by :class:`~importlib.resources.abc.Traversable`. Also fix
``ResourceContainer.iterdir()`` not calling ``resources()`` and
``ResourceHandle.joinpath`` signature mismatch with base class.
Loading