gh-146091: Fix NULL check in termios.tcsetwinsize#146147
Merged
kumaraditya303 merged 1 commit intopython:mainfrom Mar 19, 2026
Merged
gh-146091: Fix NULL check in termios.tcsetwinsize#146147kumaraditya303 merged 1 commit intopython:mainfrom
kumaraditya303 merged 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
ae90cb1 to
5e8ef92
Compare
Add proper NULL checks for PySequence_GetItem results before passing to PyLong_AsLong. This prevents SystemError when a BadSequence raises TypeError in __getitem__.
5e8ef92 to
113df89
Compare
kumaraditya303
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146091
Add proper NULL checks for PySequence_GetItem results before passing
to PyLong_AsLong, this prevents SystemError when a BadSequence raises
TypeError in getitem, the issue was that PySequence_GetItem can return NULL, which when passed to PyLong_AsLong would cause an internal error instead of propagating
the original exception.
SystemErrorfromtermios.tcsetwinsizepassingNULLtoPyLong_AsLong#146091