Skip to content

gh-146091: Fix NULL check in termios.tcsetwinsize #146147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okiemute04 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-146091: Fix NULL check in termios.tcsetwinsize #146147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-03-18-16-58-17.gh-issue-146091.lBbo1L.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a bug in :func:`termios.tcsetwinsize` where passing a sequence that
raises an exception in ``__getitem__`` would cause a :exc:`SystemError`
instead of propagating the original exception.
13 changes: 9 additions & 4 deletions Modules/termios.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,19 +500,24 @@ termios_tcsetwinsize_impl(PyObject *module, int fd, PyObject *winsz)
PyObject *tmp_item;
long winsz_0, winsz_1;
tmp_item = PySequence_GetItem(winsz, 0);
if (tmp_item == NULL) {
return NULL;
}
winsz_0 = PyLong_AsLong(tmp_item);
Py_DECREF(tmp_item);
if (winsz_0 == -1 && PyErr_Occurred()) {
Py_XDECREF(tmp_item);
return NULL;
}
Py_XDECREF(tmp_item);
tmp_item = PySequence_GetItem(winsz, 1);
if (tmp_item == NULL) {
return NULL;
}
winsz_1 = PyLong_AsLong(tmp_item);
Py_DECREF(tmp_item);
if (winsz_1 == -1 && PyErr_Occurred()) {
Py_XDECREF(tmp_item);
return NULL;
}
Py_XDECREF(tmp_item);


termiosmodulestate *state = PyModule_GetState(module);

Expand Down
Loading