Skip to content

gh-146245: Fix reference and buffer leaks via audit hook in socket module#146248

Merged
serhiy-storchaka merged 7 commits intopython:mainfrom
aisk:socket-audit-leak
Mar 22, 2026
Merged

gh-146245: Fix reference and buffer leaks via audit hook in socket module#146248
serhiy-storchaka merged 7 commits intopython:mainfrom
aisk:socket-audit-leak

Conversation

@aisk
Copy link
Member

@aisk aisk commented Mar 21, 2026

@aisk aisk changed the title gh-146245: Fix reference and buffer leaks audit hook in socket module gh-146245: Fix reference and buffer leaks via audit hook in socket module Mar 21, 2026
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

@aisk
Copy link
Member Author

aisk commented Mar 21, 2026

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

The tests are reverted.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting merge labels Mar 22, 2026
@serhiy-storchaka serhiy-storchaka merged commit c30fae4 into python:main Mar 22, 2026
94 of 102 checks passed
@miss-islington-app
Copy link

Thanks @aisk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2026
…ket module (pythonGH-146248)

(cherry picked from commit c30fae4bea9f9ba07833e97eb542754c26610765)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2026
…ket module (pythonGH-146248)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 22, 2026

GH-146274 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 22, 2026
@bedevere-app
Copy link

bedevere-app bot commented Mar 22, 2026

GH-146275 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 22, 2026
serhiy-storchaka pushed a commit that referenced this pull request Mar 22, 2026
…cket module (GH-146248) (GH-146275)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Mar 22, 2026
…cket module (GH-146248) (GH-146274)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 23, 2026
…8577

* 'main' of github.com:python/cpython:
  pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#146332)
  pythongh-146325: Use `test.support.requires_fork` in test_fastpath_cache_cleared_in_forked_child (python#146330)
  pythongh-146197: Add Emscripten to CI (python#146198)
  pythongh-143387: Raise an exception instead of returning None when metadata file is missing. (python#146234)
  pythongh-108907: ctypes: Document _type_ codes (pythonGH-145837)
  pythongh-146175: Soft-deprecate outdated macros; convert internal usage (pythonGH-146178)
  pythongh-146056: Rework ref counting in treebuilder_handle_end() (python#146167)
  Add a warning about untrusted input to `configparser` docs (python#146276)
  pythongh-145264: Do not ignore excess Base64 data after the first padded quad (pythonGH-145267)
  pythongh-146308: Fix error handling issues in _remote_debugging module (python#146309)
  pythongh-146192: Add base32 support to binascii (pythonGH-146193)
  pythongh-135953: Properly obtain main thread identifier in Gecko Collector (python#146045)
  pythongh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples (pythonGH-144300)
  pythongh-146261: Fix bug in `_Py_uop_sym_set_func_version` (pythonGH-146291)
  pythongh-145144: Add more tests for UserList, UserDict, etc (pythonGH-145145)
  pythongh-143959: Fix test_datetime if _datetime is unavailable (pythonGH-145248)
  pythongh-146245: Fix reference and buffer leaks via audit hook in socket module (pythonGH-146248)
  pythongh-140049: Colorize exception notes in `traceback.py` (python#140051)
  Update docs for pythongh-146056 (pythonGH-146213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants