Skip to content

fix return shape for place_acker (#1190) #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murrayrm wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −1
Open

fix return shape for place_acker (#1190) #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3215681
fix return shape for place_acker (#1190)
murrayrm Jan 19, 2026
8c71d6e
add mark for slycot in unit test
murrayrm Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion control/statefbk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def place_acker(A, B, poles):
pmat = pmat + p[n-i-1] * np.linalg.matrix_power(A, i)
K = np.linalg.solve(ct, pmat)

K = K[-1, :] # Extract the last row
K = K[-1:, :] # Extract the last row
return K


Expand Down
20 changes: 20 additions & 0 deletions control/tests/statefbk_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,3 +1272,23 @@ def test_create_statefbk_params(unicycle):
assert [k for k in clsys.params.keys()] == ['K', 'a', 'b']
assert clsys.params['a'] == 2
assert clsys.params['b'] == 1


@pytest.mark.parametrize('ny, nu', [(1, 1), (2, 2), (2, 1)])
@pytest.mark.parametrize(
'method', [
place, place_acker,
pytest.param(place_varga, marks=pytest.mark.slycot)])
def test_place_variants(ny, nu, method):
sys = ct.rss(states=2, inputs=nu, outputs=ny)
desired_poles = -np.arange(1, sys.nstates + 1, 1)

if method == place_acker and sys.ninputs != 1:
with pytest.raises(np.linalg.LinAlgError, match="must be square"):
K = method(sys.A, sys.B, desired_poles)
else:
K = method(sys.A, sys.B, desired_poles)

placed_poles = np.linalg.eigvals(sys.A - sys.B @ K)
np.testing.assert_array_almost_equal(
np.sort(desired_poles), np.sort(placed_poles))
Loading