Conversation
yakov116
reviewed
Jul 3, 2022
| @returns dependabot[bot] | ||
|
|
||
| */ | ||
| export default function getCommentAuthor(anyElementInsideComment: Element): string { |
Member
There was a problem hiding this comment.
Can we reuse this helper for show-names?
Member
Author
There was a problem hiding this comment.
That was the idea, just not as part of this PR
Member
Author
There was a problem hiding this comment.
show-names has to query the exact author link so this function is not useful. I don't see any other situations where it can be used (grepped author)
Member
|
Side effect on review comments:
Normal:
To be honest I kinda like it somehow emphasis the author. And it's GitHub being inconsistent here so... |
tojin12341za
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot
Test URLs
Bot PR
webpack/webpack#15926 (comment)
Bot comment
webpack/webpack#15926 (comment)
Bot commented on behalf of
webpack/webpack#15926 (comment)
Member review
#5721 (review)
Contributor review comment
#5691 (comment)
Contributor review second comment
#5691 (comment)
Contributor review second comment in Files tab
https://github.com/refined-github/refined-github/pull/2667/files#r366433031