linkify-user-labels - Disable for viewer member label, enable for collaborator label#8997
Open
SunsetTechuila wants to merge 6 commits intomainfrom
Open
linkify-user-labels - Disable for viewer member label, enable for collaborator label#8997SunsetTechuila wants to merge 6 commits intomainfrom
linkify-user-labels - Disable for viewer member label, enable for collaborator label#8997SunsetTechuila wants to merge 6 commits intomainfrom
Conversation
…ollaborator label
This doesn't work for some reason
SunsetTechuila
commented
Feb 20, 2026
|
|
||
| function init(signal: AbortSignal): void { | ||
| observe([ | ||
| 'span[data-testid="comment-author-association"][aria-label*="a member of the"]', |
Member
Author
There was a problem hiding this comment.
I don't know what was the reason to use [aria-label*="a member of the"] instead of [aria-label^="This user is a member"].
It was like that from the start: https://github.com/refined-github/refined-github/pull/5765/changes/2c2c77c85ffacb28d1f7ebae7e8140cfc0938765#diff-964f0dc23f2488134d464600f151a7b051cd026e2de58e6899c3b7d27e391f77R11
Member
Author
There was a problem hiding this comment.
I doubt that the tooltip text used to start with a username
Member
There was a problem hiding this comment.
The links in the original PR might have the answer: #5765
Do comments and PRs by bots/apps say "this user"?
Member
Author
There was a problem hiding this comment.
Do comments and PRs by bots/apps say "this user"?
Yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs
https://github.com/editorconfig/editorconfig-emacs/pull/389/changes#r2809824690
Screenshot