Skip to content

Comments

feat!: Add dedicated -metrics service#748

Merged
sbernauer merged 17 commits intomainfrom
feat/more-prom-metrics
Jul 24, 2025
Merged

feat!: Add dedicated -metrics service#748
sbernauer merged 17 commits intomainfrom
feat/more-prom-metrics

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 22, 2025 •
edited by maltesander
Loading

Description

Part of stackabletech/issues#692

The metrics Service was missed, as we skipped the listener rollout to OPA.

Also add a test that actually scrapes Prometheus metrics.

See changelog for detailed changes.

k get svc -A | grep -P 'simple-zk|test-opa'                                                                                kind-kind
default                  simple-zk-server                    ClusterIP   10.96.56.205   <none>        2282/TCP                 82m
default                  simple-zk-server-default-headless   ClusterIP   None           <none>        2888/TCP,3888/TCP        82m
default                  simple-zk-server-default-metrics    ClusterIP   None           <none>        9505/TCP,7000/TCP        82m
kuttl-test-causal-bass   test-opa-server                     ClusterIP   10.96.164.60   <none>        8081/TCP                 52s
kuttl-test-causal-bass   test-opa-server-default-headless    ClusterIP   None           <none>        8081/TCP                 52s
kuttl-test-causal-bass   test-opa-server-default-metrics     ClusterIP   None           <none>        8081/TCP                 52s

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

sbernauer
sbernauer commented Jul 22, 2025
View reviewed changes
@sbernauer sbernauer mentioned this pull request Jul 22, 2025
Closed
4 tasks
@maltesander maltesander self-requested a review July 22, 2025 08:56
maltesander
maltesander previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sbernauer and others added 2 commits July 22, 2025 12:52
@sbernauer @maltesander
Update rust/operator-binary/src/controller.rs
3fd592e 
Co-authored-by: Malte Sander <contact@maltesander.com>
@sbernauer
changelog
bec72ee
@sbernauer sbernauer requested a review from maltesander July 22, 2025 10:58
@sbernauer
Copy link
Member Author

sbernauer commented Jul 22, 2025

Not merging now, waiting for the SDP 25.7 release team to update the changelog in main

@sbernauer
Copy link
Member Author

sbernauer commented Jul 24, 2025

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/26/

maltesander
maltesander previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer @maltesander
Update CHANGELOG.md
a43bcb2 
Co-authored-by: Malte Sander <contact@maltesander.com>
maltesander
maltesander previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

sbernauer commented Jul 24, 2025

All tests passed locally:

--- PASS: kuttl (190.84s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/resources_opa-latest-1.4.2_openshift-false (20.14s)
        --- PASS: kuttl/harness/aas-user-info_opa-latest-1.4.2_openshift-false (76.00s)
        --- PASS: kuttl/harness/logging_opa-1.4.2_openshift-false (65.10s)
        --- PASS: kuttl/harness/smoke_opa-1.0.1_openshift-false (99.10s)
        --- PASS: kuttl/harness/logging_opa-1.0.1_openshift-false (100.43s)
        --- PASS: kuttl/harness/cluster-operation_opa-latest-1.4.2_openshift-false (36.03s)
        --- PASS: kuttl/harness/smoke_opa-1.4.2_openshift-false (59.13s)
        --- PASS: kuttl/harness/keycloak-user-info_opa-latest-1.4.2_keycloak-23.0.1_openshift-false (114.83s)
PASS

@sbernauer sbernauer enabled auto-merge July 24, 2025 12:20
maltesander
maltesander previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer disabled auto-merge July 24, 2025 12:27
@sbernauer sbernauer requested a review from maltesander July 24, 2025 12:30
@sbernauer sbernauer enabled auto-merge July 24, 2025 12:31
@sbernauer sbernauer added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 73ffb27 Jul 24, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/more-prom-metrics branch July 24, 2025 12:47
@sbernauer sbernauer added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/25.11.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Sep 22, 2025
@sbernauer
Copy link
Member Author

sbernauer commented Sep 22, 2025

Release notes

Added

  • Add a dedicated per-rolegroup -metrics Service, which can be used to get Prometheus metrics
  • Expose more Prometheus metrics, such as successful or failed bundle loads and information about the OPA environment

Changed

  • BREAKING: The per-rolegroup services now only serves the HTTP port and has a -headless suffix to better indicate their purpose and to be consistent with other operators ([feat!: Add dedicated -metrics service #748]).

dervoeti pushed a commit that referenced this pull request Oct 29, 2025
@sbernauer @maltesander @dervoeti
feat!: Add dedicated -metrics service (#748)
fd9a7e9 
* feat!: Add dedicated -metrics service

* changelog

* improve doc comment

* linter

* linter

* Add container port

* fix port problem

* fix tests und role service name

* fix linter

* Update rust/operator-binary/src/controller.rs

Co-authored-by: Malte Sander <contact@maltesander.com>

* changelog

* changelog

* changelog

* Update CHANGELOG.md

Co-authored-by: Malte Sander <contact@maltesander.com>

* fix tests

* ruff ruff

---------

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
@sbernauer sbernauer mentioned this pull request Nov 27, 2025
Closed
@adwk67 adwk67 mentioned this pull request Jan 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

No one assigned

Labels

release/25.11.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @maltesander