chore(deps): Update monaco-yaml package to 5 branch#10272
chore(deps): Update monaco-yaml package to 5 branch#10272
Conversation
|
Images are ready for the commit at 3b896cd. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10272 +/- ##
=======================================
Coverage 47.96% 47.96%
=======================================
Files 2420 2420
Lines 169393 169393
=======================================
+ Hits 81247 81254 +7
+ Misses 81461 81456 -5
+ Partials 6685 6683 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/test ocp-4-11-ui-e2e-tests |
1 similar comment
|
/test ocp-4-11-ui-e2e-tests |
| toolTipText={labels.downloadYAML} | ||
| tooltipProps={{ | ||
| content: labels.downloadYAML, | ||
| }} |
There was a problem hiding this comment.
Would you happen to know if the tooltip was working before? I'll let you decide if adding a test to check the tooltip is worth it.
|
Closing this, because all the necessary changes were done as part of the PatternFly 5 upgrade effort. |
Description
Found this outdated package when investigating the dependency tree for another outdated package (
yaml). Updating the other package will require more involved changes, but this one is a relatively easy fix.Also, fixed a prop deprecation warning in the console that already existed, even with the original 4.x outdated version of
monaco-yamlChecklist
Testing Performed
Here I tell how I validated my change
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.