Merged
Conversation
|
Skipping CI for Draft Pull Request. |
dvail
commented
Mar 25, 2024
| "monaco-editor": "^0.21.3", | ||
| "monaco-editor-webpack-plugin": "^2.1.0", | ||
| "monaco-yaml": "^4.0.4", | ||
| "monaco-editor": "^0.34.1", |
Contributor
Author
There was a problem hiding this comment.
| "mobx": "^6.9.0", | ||
| "mobx-react": "^7.6.0", | ||
| "monaco-editor": "^0.21.3", | ||
| "monaco-editor-webpack-plugin": "^2.1.0", |
Contributor
Author
There was a problem hiding this comment.
| "react-feather": "^2.0.9", | ||
| "react-helmet": "^6.1.0", | ||
| "react-modal": "^3.12.1", | ||
| "react-monaco-editor": "^0.51.0", |
Contributor
Author
There was a problem hiding this comment.
No longer a required peer dep, as of patternfly/patternfly-react#9842
vjwilson
approved these changes
Mar 25, 2024
Contributor
|
Images are ready for the commit at 1b481da. To use with deploy scripts, first |
dvail
added a commit
that referenced
this pull request
Mar 25, 2024
dvail
added a commit
that referenced
this pull request
Mar 27, 2024
dvail
added a commit
that referenced
this pull request
Mar 29, 2024
vjwilson
pushed a commit
that referenced
this pull request
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates Monaco dependencies for the PF5 upgrade to prevent crashing of the CodeEditor component.
Additionally includes monaco-yaml changes from #10272 (thanks @vjwilson!)
Checklist
If any of these don't apply, please comment below.
Testing Performed
Visit Violation => Network Policies and open the Netpol modal:
Darkmode:
Verify Copy and Export buttons work correctly
Visit Network Graph and click a deployment, viewing the CodeEditor:
Darkmode:
Visit Network Graph and run netpol generator, again, testing custom button controls and darkmode:
Verify Copy and Export buttons work correctly