ROX-24132: Build manifests if all archs are available per brand#11593
Merged
gavin-stackrox merged 7 commits intomasterfrom Jun 24, 2024
Merged
ROX-24132: Build manifests if all archs are available per brand#11593gavin-stackrox merged 7 commits intomasterfrom
gavin-stackrox merged 7 commits intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at 0dca1fd. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11593 +/- ##
=======================================
Coverage 48.00% 48.01%
=======================================
Files 2358 2358
Lines 169314 169360 +46
=======================================
+ Hits 81282 81321 +39
- Misses 81516 81520 +4
- Partials 6516 6519 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7bd2633 to
0e6b78f
Compare
0e6b78f to
dbc36a1
Compare
This reverts commit 6377e4b.
msugakov
reviewed
Jun 20, 2024
1 task
msugakov
approved these changes
Jun 21, 2024
shireenf-ibm
pushed a commit
to shireenf-ibm/stackrox
that referenced
this pull request
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per title. See ROX-24132.
Checklist
Testing Performed
Here I tell how I validated my change
Test 1: break pre-build-ui / STACKROX_BRANDING
Run 1 - break STACKROX_BRANDING
I had expected the
pre-build-uistep with STACKROX_BRANDING to fail due to75dea4a(#11593). But the UI artifact is built but with an incorrect artifact name. The downstream image build steps fail as expected. And the manifest fails to push due to missing contents. RHACS_BRANDING is still pushed and e2e tests ran.Run 2 - really break STACKROX_BRANDING
dbc36a1(#11593) does the deed.Test 2: break build-and-push-main / STACKROX_BRANDING / amd64
Run 3 - break build-and-push-main / STACKROX_BRANDING / amd64
6377e4b(#11593)Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.