fix(CI): artifact download/upload retry & failure propagation#11637
fix(CI): artifact download/upload retry & failure propagation#11637gavin-stackrox merged 7 commits intomasterfrom
Conversation
|
Images are ready for the commit at 9b3cb7e. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11637 +/- ##
=======================================
Coverage 48.02% 48.02%
=======================================
Files 2358 2358
Lines 169364 169364
=======================================
+ Hits 81329 81338 +9
+ Misses 81511 81504 -7
+ Partials 6524 6522 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@gavin-stackrox: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
Description
When checking #11593 I noticed that the download-artifact-with-retry action was not retrying and was not propagating error to its users. This was due to the steps using
name:as the reference for outcome where it should beid:. This also causes the propagation error because thecontinue-on-error: truein the first step is propagated to the action user (build.yamlin this case).Checklist
Testing Performed
Here I tell how I validated my change
idon this PR. Retry is attempted and failure is propagated: https://github.com/stackrox/stackrox/actions/runs/9603709451/job/26487955525#step:10:1Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.