Skip to content

(obsolete) ROX-24468: Retag ScannerV2 and Collector containers#12430

Closed
msugakov wants to merge 18 commits intomasterfrom
misha/ROX-24468-retag-in-konflux
Closed

(obsolete) ROX-24468: Retag ScannerV2 and Collector containers#12430
msugakov wants to merge 18 commits intomasterfrom
misha/ROX-24468-retag-in-konflux

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Aug 16, 2024

Description

change me!

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Aug 16, 2024 •
edited
Loading

Images are ready for the commit at 3490c94.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-517-g3490c94526.

@codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.17%. Comparing base (1e3a7d4) to head (3490c94).
Report is 42 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #12430   +/-   ##
=======================================
  Coverage   48.17%   48.17%           
=======================================
  Files        2434     2434           
  Lines      174117   174159   +42     
=======================================
+ Hits        83876    83906   +30     
- Misses      83467    83476    +9     
- Partials     6774     6777    +3
Flag Coverage Δ
go-unit-tests 48.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msugakov msugakov force-pushed the misha/ROX-24468-retag-in-konflux branch 4 times, most recently from 11c7ebc to 475ab0c Compare August 16, 2024 10:56
@msugakov
Copy link
Contributor Author

msugakov commented Aug 16, 2024

/retest

@msugakov
Copy link
Contributor Author

msugakov commented Aug 16, 2024

https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/collector-full-retag-mlw29
Sure, build args aren't supported on buildah-remote https://issues.redhat.com/browse/KFLUXBUGS-1495 and so building with Dockerfile won't work.
Although we can try retag through creating an image manifest.

@msugakov msugakov force-pushed the misha/ROX-24468-retag-in-konflux branch from ac19325 to e1ca496 Compare August 16, 2024 15:17
@msugakov msugakov force-pushed the misha/ROX-24468-retag-in-konflux branch from e1ca496 to b6bfb93 Compare September 10, 2024 19:04
@msugakov
DO NOT MERGE: temporarily disable all other builds
67e4acb 
to iterate quickly and not cause too many Konflux builds
@msugakov
Prepare pipeline for retagging collector
60914d6 
as simply a copy of roxctl/basic-component pipeline.
Further changes will go on top of that.
@msugakov
Adjust pipeline for retagging, with dummy Dockerfile
eca239f
@msugakov
Extend determine-image-tag task to get collector/scanner tags
3eb8b04
@msugakov
Plug base image into dockerfile
87225e9
@msugakov
Try use build-image-manifest as a way to retag
4d58f23
@msugakov
Delete retag.Dockerfile
3b80597 
because there's no need in it
@msugakov
Reformat retag-pipeline.yaml
d845f90
@msugakov
Synchronize retag-pipeline.yaml from the fresh basic one
b5cf781
@msugakov
Reformat once more
d92e09a
@msugakov
Update and move collector full retagging
776b738
@msugakov
Add collector-slim retag pipeline
324afda
@msugakov
Remove build-source-image and sast-snyk-check
dfb918c 
because these pipelines may overwrite the original side-artifacts
and we don't want that.
@msugakov
Remove prefetch because nothing depends on it any more
8686d35
@msugakov
fixup! Remove build-source-image and sast-snyk-check
bc2455b
@msugakov
Remove path-context and dockerfile
91d52f4
@msugakov
Remove hermetic param
cd8c97a 
because nothing reads it as well
@msugakov
Remove java param
3490c94
@msugakov msugakov force-pushed the misha/ROX-24468-retag-in-konflux branch from ee6f29d to 3490c94 Compare September 13, 2024 16:13
@msugakov msugakov mentioned this pull request Sep 17, 2024
Closed
9 tasks
@msugakov msugakov changed the title ROX-24468: Retag ScannerV2 and Collector containers (obsololete) ROX-24468: Retag ScannerV2 and Collector containers Sep 18, 2024
@msugakov msugakov changed the title (obsololete) ROX-24468: Retag ScannerV2 and Collector containers (obsolete) ROX-24468: Retag ScannerV2 and Collector containers Sep 18, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Sep 19, 2024

Closing in favor of #12724

@msugakov msugakov closed this Sep 19, 2024
@msugakov msugakov mentioned this pull request Oct 25, 2024
Merged
5 tasks
@msugakov msugakov deleted the misha/ROX-24468-retag-in-konflux branch May 27, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhacs-bot rhacs-bot Awaiting requested review from rhacs-bot rhacs-bot will be requested when the pull request is marked ready for review rhacs-bot is a code owner

Assignees

No one assigned

Labels

do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msugakov @rhacs-bot