ROX-24468: Retag ScannerV2 and Collector containers#13079
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 659424a. To use with deploy scripts, first |
be99942 to
e4fc9ce
Compare
40e4641 to
f7992d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13079 +/- ##
==========================================
- Coverage 48.50% 48.50% -0.01%
==========================================
Files 2468 2468
Lines 178017 178017
==========================================
- Hits 86351 86348 -3
- Misses 84735 84737 +2
- Partials 6931 6932 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f363482 to
989e9e3
Compare
3749ee0 to
6659ba8
Compare
|
I think this is ready for review, although collector-*-retag pipelines are failing due to |
6659ba8 to
1c39d81
Compare
f3f15c1 to
978ae6d
Compare
tommartensen
left a comment
There was a problem hiding this comment.
Mostly tiny remarks, great work so far!
978ae6d to
38a4487
Compare
052c4a1 to
659424a
Compare
|
/retest main-on-push |
|
/retest operator-on-push |
|
/retest operator-bundle-on-push |
Comparing for
|
Comparing for
|
|
I have access to EC at the moment and it does not look great, but I'm going to merge it and follow-up in the task because this PR has been open for too long and at this point builds complete fine. |
We can try to get help from #konflux-users for these open issues. |
Description
See the ticket ROX-24468.
This also addresses ROX-26471.
Why invent our own task? Release pipelines have something similar https://github.com/konflux-ci/release-service-catalog/blob/development/tasks/push-snapshot/push-snapshot.yaml but that works with Snapshots and we need to copy at the image level and I don't see an easy way to adapt. Eventually, the logic is not that terrible so I hope we'd be ok to maintain it.
Replaces #12724 and #12430.
User-facing documentation
Testing and quality
Automated testing
No change to automated testing.
How I validated my change