ROX-25572: prefetch dependencies for operator-bundle on Konflux#12651
ROX-25572: prefetch dependencies for operator-bundle on Konflux#12651tommartensen wants to merge 32 commits intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 05da7ae. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12651 +/- ##
==========================================
- Coverage 48.24% 48.23% -0.01%
==========================================
Files 2452 2452
Lines 176454 176454
==========================================
- Hits 85122 85119 -3
- Misses 84484 84486 +2
- Partials 6848 6849 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retest |
|
@tommartensen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
To overcome build error like ``` Go compliance shim [1209] [rhel-9-golang-1.22][openshift-golang-builder]: invoking real go binary go: inconsistent vendoring in /stackrox/operator/tools/operator-sdk: github.com/operator-framework/operator-lifecycle-manager@v0.27.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt github.com/operator-framework/operator-sdk@v1.36.1: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt github.com/AdaLogics/go-fuzz-headers@v0.0.0-20230811130428-ced1acdcaa24: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt github.com/Azure/go-ansiterm@v0.0.0-20230124172434-306776ec8161: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt github.com/BurntSushi/toml@v1.3.2: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt github.com/MakeNowJust/heredoc@v1.0.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt ``` In https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/operator-bundle-build-swhjj Borrowed from #12651 but excluding Python stuff.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13717494 | Triggered | Generic Private Key | 0f50bbc | central/clusterinit/backend/testdata/crs-key.pem | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
msugakov
left a comment
There was a problem hiding this comment.
Great that you found a way!
| @@ -0,0 +1,19 @@ | |||
| attrs==24.2.0 | |||
There was a problem hiding this comment.
I did not know about requirements-build.txt before and it seems to be Cachi2 thing.
What was the reason you decided to build from sdists instead of using wheels (as described here)?
If we stay with requirements-build.txt, we need instructions how to update it when we change versions in requirements.txt or add new dependencies there.
There was a problem hiding this comment.
I saw wheels support was just announced https://groups.google.com/a/redhat.com/g/konflux-announce/c/QILABamxDtA/m/5wK53cnlAgAJ
Description
Changes:
requirements-build.txtCurrent status:
quay.io/rhacs-eng/stackrox-operator-bundle:v4.6.0-538-g74075d97fc-fastbefore).TODO
python3-develinstall though!User-facing documentation
Testing and quality
Automated testing
- [ ] added unit tests- [ ] added e2e tests- [ ] added regression tests- [ ] added compatibility tests- [ ] modified existing testsHow I validated my change
Builds on Konflux.