chore: Add CGO_ENABLED for konflux operator bundle#12962
chore: Add CGO_ENABLED for konflux operator bundle#12962
Conversation
If some go is compiled in this image later, then do we also need to set CGO_ENABLED to ensure a fips compliant build?
|
Skipping CI for Draft Pull Request. |
|
The golang image was used to get a newer go version to compile the operator-sdk: At that time the GOFLAGS setting was followed with a Line 432 in 6a0b2a2 Skimming over the patch-csv.py script that is run instead of the make call, I think the operator-sdk is not used now in this stage. |
|
What happens here is that some Let's see if Konflux CI for the operator-bundle will be green and then I'll gladly approve. |
|
I'm sorry I modified my last comment as I thought you would not see this until tomorrow. |
|
I proposed adding the CGO_ENABLED variable since I do not know the use of this image, but I think after looking at it more that the build layer does not need golang anymore and is all python. |
|
No-no, there is some Go compilation, otherwise I would not have to fight with build errors and add |
|
Apologies that I parachuted in here. If there is compilation, then I'll confirm the tests pass and pursue getting this merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12962 +/- ##
==========================================
- Coverage 48.14% 48.14% -0.01%
==========================================
Files 2446 2446
Lines 176070 176070
==========================================
- Hits 84776 84774 -2
- Misses 84467 84469 +2
Partials 6827 6827
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'll try this again after days have passed. It looks like there are unrelated problems in konflux. |
If some go is compiled in this image, then do we also need to set CGO_ENABLED to ensure a fips compliant build?
It looks like we do not compile go in this builder stage, and only modify text. But I am not familiar with the operator bundle or why it is using the golang image for the builder stage.