chore(ui): Increase cypress requestTimeout to 20 seconds#12852
chore(ui): Increase cypress requestTimeout to 20 seconds#12852pedrottimark merged 1 commit intomasterfrom
Conversation
|
Images are ready for the commit at e25df09. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12852 +/- ##
=======================================
Coverage 48.15% 48.15%
=======================================
Files 2439 2439
Lines 175096 175096
=======================================
Hits 84326 84326
- Misses 83969 83970 +1
+ Partials 6801 6800 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@pedrottimark: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dvail
left a comment
There was a problem hiding this comment.
No real downside to doing this in my opinion. 👍
Description
As discussed in team meeting, see effect of
requestTimeouton occasional test failures for generic requestsHistory: increased from default 5 seconds to 10 seconds about 2 years ago on 2022-10-04 in #3307
https://docs.cypress.io/guides/references/configuration#Timeouts
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI