ROX-12956: Increase requestTimeout and disable colors for integration tests#3307
Merged
pedrottimark merged 2 commits intomasterfrom Oct 5, 2022
Merged
Conversation
|
Images are ready for the commit at 05adf5c. To use with deploy scripts, first |
vjwilson
approved these changes
Oct 5, 2022
2 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test failure
cypress/integration/policies/policyWizardStep3.test.js
Unlike featureflags or mypermissions, this generic request does not block rendering the page. The page renders spinner because waiting for its requests.
Analysis
This is the third investigation to examine the build-log.text file. The second was in #3268
Compare 5 occurrences of Refreshing the GKE auth token. TL;DR see 4 below
During video processing and docs.test.js which is an external link which does not have API requests.
During video processing and maybe after the last test had finished.
Maybe before the first test had started.
Bingo! picture above is for
should populate select dropdownDuring video processing between test files.
Solution
After having added intercept-interact-wait sandwiches for test-specific requests to vulnmanagement and configmanagement, the last containers that lacked the pattern, this policies test already has up-to-date helper functions.
The next step to improve reliability is increase timeout for all requests.
Edit scripts/cypress.sh
To simplify search and eliminate editing, disable color in cypress output to build-log.txt file.
https://docs.cypress.io/guides/continuous-integration/introduction#Colors
Edit cypress.config.js
Double
requestTimeoutfrom 5000 to 10000 milliseconds.https://docs.cypress.io/guides/references/configuration#Timeouts
Delete
waitOptionsbecause defaultresponseTimeoutis30000Checklist
Testing Performed