ROX-25912: Make Kube SA token m2m auth config dynamic#12969
Merged
Conversation
c1ec149 to
8111e71
Compare
Contributor
|
Images are ready for the commit at 6bbda75. To use with deploy scripts, first |
8111e71 to
1702a24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12969 +/- ##
=======================================
Coverage 48.89% 48.89%
=======================================
Files 2547 2547
Lines 186992 186896 -96
=======================================
- Hits 91426 91386 -40
+ Misses 88324 88275 -49
+ Partials 7242 7235 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This allows customers to add their own role mappings for this config. If a customer breaks config-controller auth, they can simply restart Central to get it back to a working state. Adds a function configureConfigControllerAccess to the initialization of the token exchangers that ensures the config-controller has access to Central APIs via k8s service account token m2m auth. What this function does in plain english: * See if any existing m2m configs from the db are for the kube sa issuer * If yes, make sure the role mapping for config-controller is present * If no, create a new m2m config for kube sa issuer like we do today and save it to the db
1702a24 to
dfc508e
Compare
kylape
commented
Mar 28, 2025
Contributor
Author
|
/test gke-upgrade-tests |
clickboo
approved these changes
Mar 28, 2025
Contributor
clickboo
left a comment
There was a problem hiding this comment.
minor nits, looks good otherwise
Contributor
Author
|
/test ocp-4-12-nongroovy-e2e-tests |
parametalol
reviewed
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kube SA token m2m auth config that exists now is added for policy as code and hard codes a role mapping to the config-controller service account. This effectively locks out any other user from using the m2m config for any other purpose. This change tries to allow users to configure the Kube SA token m2m auth config while the required role mapping for policy-as-code remains intact.