Skip to content

ROX-28697: use Walk instead of GetAll in m2m#14758

Merged
janisz merged 6 commits intomasterfrom
ROX-15902_use_walk_in_auth_m2m
Apr 7, 2025
Merged

ROX-28697: use Walk instead of GetAll in m2m#14758
janisz merged 6 commits intomasterfrom
ROX-15902_use_walk_in_auth_m2m

Conversation

@janisz janisz requested a review from a team as a code owner March 26, 2025 12:27
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 26, 2025

Images are ready for the commit at 56c5ed6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-393-g56c5ed63dc.

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (6db52e7) to head (56c5ed6).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
central/auth/datastore/telemetry.go 0.00% 9 Missing ⚠️
central/auth/datastore/datastore_impl.go 61.90% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14758      +/-   ##
==========================================
- Coverage   49.01%   49.01%   -0.01%     
==========================================
  Files        2546     2546              
  Lines      186939   186953      +14     
==========================================
+ Hits        91632    91635       +3     
- Misses      88056    88066      +10     
- Partials     7251     7252       +1     
Flag Coverage Δ
go-unit-tests 49.01% <51.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

janisz added 2 commits April 4, 2025 14:29
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>

# Conflicts:
#	central/auth/datastore/datastore_impl.go
#	central/auth/store/store.go
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the ROX-15902_use_walk_in_auth_m2m branch from e963b36 to 2a7d064 Compare April 4, 2025 12:29
@janisz janisz marked this pull request as draft April 4, 2025 12:32
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
Copy link
Contributor Author

janisz commented Apr 4, 2025

Unfortunately this PR get conflicted with (#12969 )

janisz added 2 commits April 4, 2025 15:09
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested review from kylape and rhybrillou April 4, 2025 13:18
@janisz janisz marked this pull request as ready for review April 4, 2025 13:19
@janisz janisz merged commit f1b3777 into master Apr 7, 2025
92 checks passed
@janisz janisz deleted the ROX-15902_use_walk_in_auth_m2m branch April 7, 2025 12:30
@janisz janisz mentioned this pull request Apr 16, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants