ROX-26601: Use downstream image repos in operator bundle#13154
ROX-26601: Use downstream image repos in operator bundle#13154mclasmeier merged 10 commits intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 36bf4c4. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13154 +/- ##
=======================================
Coverage 48.55% 48.56%
=======================================
Files 2467 2467
Lines 177807 177824 +17
=======================================
+ Hits 86339 86354 +15
- Misses 84538 84539 +1
- Partials 6930 6931 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
87642af to
caf58f9
Compare
caf58f9 to
e86e1a0
Compare
8d142ce to
667b0e2
Compare
|
@mclasmeier: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
14773a1 to
2d7820f
Compare
|
PipelineRun for operator-bundle succeeded: https://github.com/stackrox/stackrox/pull/13154/checks?check_run_id=32808387556. |
msugakov
left a comment
There was a problem hiding this comment.
I like the new descriptions.
Co-authored-by: Moritz Clasmeier <mclasmeier@redhat.com>
Co-authored-by: Moritz Clasmeier <mclasmeier@redhat.com>
Co-authored-by: Moritz Clasmeier <mclasmeier@redhat.com>
Description
This PR modifies the image references in the Konflux-built operator-bundle to point to the expected downstream image registries (
registry.redhat.io/advanced-cluster-security/...) instead ofquay.io/rhacs-eng/....For convenience during development an
ImageContentSourcePolicyhas been provided which allows testing built operator-bundles prior to a release.User-facing documentation
Testing and quality
Automated testing
We have no automated testing for downstream bundles artifacts.
How I validated my change
We can easily deploy standalone bundles using a recent (unreleased) version of
operator-sdk.(cd operator; rm .gotools/bin/operator-sdk; make operator-sdk)NS=bundle-testkubectl create namespace bundle-test./deploy/common/pull-secret.sh quay-ips quay.io | kubectl -n $NS apply -f -cd operator/BUNDLE_TAG=v4.7.0-60-g8d142cef9f`make which-operator-sdk` run bundle quay.io/rhacs-eng/stackrox-operator-bundle:$BUNDLE_TAG --pull-secret-name quay-ips --service-account default --namespace $NSObserve that it fails to deploy, because the images refer to the downstream registry where the images do not exist:
Describing the
rhacs-operator-controller-managerpod:as expected.
Second test:
cd operator/`make which-operator-sdk` cleanup --delete-all rhacs-operatorImageContentSourcePolicythe the cluster:`make which-operator-sdk` cleanup --delete-all rhacs-operator`make which-operator-sdk` run bundle quay.io/rhacs-eng/stackrox-operator-bundle:$BUNDLE_TAG --pull-secret-name quay-ips --service-account default --namespace $NSObserve that it deployed alright with images being fetched from quay.io:
Pods:
Applying a Central CR causes central to come up healthy:
After having produced an init-bundle in the shape of a Kubernetes secret and applied it we can proceed with deploying a SecuredCluster.