Skip to content

ROX-26901: Add securitypolicies CRD to Konflux operator-bundle#13264

Merged
mclasmeier merged 1 commit intomasterfrom
mc/konflux-operator-bundle-securitypolicies
Nov 11, 2024
Merged

ROX-26901: Add securitypolicies CRD to Konflux operator-bundle#13264
mclasmeier merged 1 commit intomasterfrom
mc/konflux-operator-bundle-securitypolicies

Conversation

@mclasmeier
Copy link
Contributor

@mclasmeier mclasmeier commented Nov 7, 2024

Description

Recently a new CRD was added to operator-bundles. This PR does the same for the Konflux-built bundles.

The same commit is present also in #13154, which is where the resulting artifacts have been inspected to verify that the CRD is included.

User-facing documentation

  • CHANGELOG update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready
  • CI results are inspected

Automated testing

None currently.

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mclasmeier mclasmeier changed the title Add securitypolicies to Konflux-built operator-bundle ROX-26901: Add securitypolicies to Konflux-built operator-bundle Nov 7, 2024
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 7, 2024

Images are ready for the commit at b88ca0c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-70-gb88ca0c86d.

@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.50%. Comparing base (789781f) to head (b88ca0c).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13264   +/-   ##
=======================================
  Coverage   48.50%   48.50%           
=======================================
  Files        2468     2468           
  Lines      178017   178017           
=======================================
+ Hits        86345    86348    +3     
+ Misses      84738    84736    -2     
+ Partials     6934     6933    -1     
Flag Coverage Δ
go-unit-tests 48.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mclasmeier mclasmeier force-pushed the mc/konflux-operator-bundle-securitypolicies branch from f941a93 to 03ca1fd Compare November 8, 2024 08:27
@mclasmeier mclasmeier changed the title ROX-26901: Add securitypolicies to Konflux-built operator-bundle ROX-26901: Add securitypolicies CRD to Konflux operator-bundle Nov 8, 2024
@mclasmeier mclasmeier force-pushed the mc/konflux-operator-bundle-securitypolicies branch from bd03d16 to b88ca0c Compare November 8, 2024 10:37
@mclasmeier mclasmeier marked this pull request as ready for review November 8, 2024 12:30
@mclasmeier mclasmeier requested a review from a team as a code owner November 8, 2024 12:30
@mclasmeier mclasmeier requested review from porridge and removed request for a team November 8, 2024 12:30
@mclasmeier mclasmeier requested a review from msugakov November 8, 2024 12:30
@mclasmeier mclasmeier added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Nov 11, 2024
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is present in release-4.6 branch, therefore approving.
https://github.com/stackrox/stackrox/blob/release-4.6/operator/Makefile#L444

@mclasmeier mclasmeier merged commit b80256b into master Nov 11, 2024
@mclasmeier mclasmeier deleted the mc/konflux-operator-bundle-securitypolicies branch November 11, 2024 11:30
RUN mkdir -p build/ && \
rm -rf build/bundle && \
cp -a bundle build/ && \
cp -v ../config-controller/config/crd/bases/config.stackrox.io_securitypolicies.yaml build/bundle/manifests/ && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say I'm not a huge fan of the duplication between the Makefile and this dockerfile ☹️
We missed this once, we will likely miss something again in the future...
I'll file a ticket to track this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaa5kameric pushed a commit that referenced this pull request Nov 14, 2024
Co-authored-by: Moritz Clasmeier <mclasmeier@redhat.com>
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
Co-authored-by: Moritz Clasmeier <mclasmeier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/operator backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants