ROX-25572: prefetch dependencies for operator-bundle on Konflux#13209
Merged
tommartensen merged 11 commits intomasterfrom Nov 6, 2024
Merged
ROX-25572: prefetch dependencies for operator-bundle on Konflux#13209tommartensen merged 11 commits intomasterfrom
tommartensen merged 11 commits intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 5bc5967. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13209 +/- ##
==========================================
- Coverage 48.50% 48.50% -0.01%
==========================================
Files 2468 2468
Lines 177995 177999 +4
==========================================
- Hits 86334 86332 -2
- Misses 84728 84733 +5
- Partials 6933 6934 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
/retest roxctl-on-push |
|
@tommartensen: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/retest roxctl-on-push |
|
@tommartensen: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
msugakov
reviewed
Nov 5, 2024
Contributor
msugakov
left a comment
There was a problem hiding this comment.
Looks good! Please enable hermetic and I'll gladly approve
Contributor
Author
|
/test gke-sensor-integration-tests |
msugakov
approved these changes
Nov 5, 2024
Contributor
msugakov
left a comment
There was a problem hiding this comment.
Please address the new comments before merging.
|
@tommartensen: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
1 task
aaa5kameric
pushed a commit
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
ajheflin
pushed a commit
that referenced
this pull request
Jun 24, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prefetch the Python dependencies required to run
patch-csv.pybundle helpers script.This will fill the CSV template with information about related images, ...
We can switch to the Python image as builder, because we don't use Go anymore to construct, patch and test the CSV.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
konflux.bundle.Dockerfilehermetic: truein bundle build pipelineValidation build: https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/operator-bundle-on-push-hcgr2 (Commit: f6c5ac0)
Then reverted those changes and ran a full validation pipeline: https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/operator-bundle-on-push-cxsf8
We see that
prefetch-dependenciesfetched our required dependencies and artifacts were used during the build.