Skip to content

ci: return bundle build to ubi9, remove golang builder use#13218

Closed
davdhacs wants to merge 1 commit intomasterfrom
konflux-remove-unused-golang-env-for-operator-bundle
Closed

ci: return bundle build to ubi9, remove golang builder use#13218
davdhacs wants to merge 1 commit intomasterfrom
konflux-remove-unused-golang-env-for-operator-bundle

Conversation

@davdhacs
Copy link
Contributor

@davdhacs davdhacs commented Nov 4, 2024

Description

note: Change requested only to simplify the image build: remove build layer and GOFLAGS variable. Not fixing anything in the created image.

For operator/konflux.bundle.Dockerfile,

  • Return operator bundle build to ubi9 base image (remove use of openshift-golang-builder).
  • Remove GOFLAGS variable (un)set.

The openshift-golang-builder was added because the ubi9 image did not have golang 1.22 required for building the operator-sdk: #12687
The operator-sdk compilation was removed from the bundle build in https://github.com/stackrox/stackrox/pull/12797/files#diff-a0bd03066e74bedcc5176486cfb75755731e939937c28281f6dc3cbc7a470953L26

Testing and quality

  • CI results are inspected

How I validated my change

Initially proposed adding the CGO_ENABLED flag to make sure built golang binaries would be FIPS compliant, but I found no golang binaries built by it: #12962

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@davdhacs davdhacs added konflux-build Run Konflux in PR. Push commit to trigger it. and removed area/operator labels Nov 4, 2024
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at d46fda9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-36-gd46fda9c4c.

@davdhacs
Copy link
Contributor Author

davdhacs commented Nov 4, 2024

I'm not sure how to test these images in the e2e CI. I looked at another PR and I do not see e2e runs with konflux images.

@davdhacs
Copy link
Contributor Author

davdhacs commented Nov 4, 2024

/test all

@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.50%. Comparing base (754c017) to head (d46fda9).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13218      +/-   ##
==========================================
- Coverage   48.50%   48.50%   -0.01%     
==========================================
  Files        2468     2468              
  Lines      177995   177995              
==========================================
- Hits        86334    86329       -5     
- Misses      84729    84733       +4     
- Partials     6932     6933       +1     
Flag Coverage Δ
go-unit-tests 48.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommartensen
Copy link
Contributor

Obsolete with #13209.

@davdhacs davdhacs closed this Nov 6, 2024
@davdhacs davdhacs deleted the konflux-remove-unused-golang-env-for-operator-bundle branch September 10, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants