Skip to content

ROX-27203: Ensure collector/scanner images exist during updates#13502

Merged
tommartensen merged 14 commits intomasterfrom
tm/ROX-27203-wait-for-collector-images
Dec 10, 2024
Merged

ROX-27203: Ensure collector/scanner images exist during updates#13502
tommartensen merged 14 commits intomasterfrom
tm/ROX-27203-wait-for-collector-images

Conversation

@tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Dec 3, 2024

Description

Ensure that GHA and Konflux built images are present when attempting to update the SCANNER_VERSION, COLLECTOR_VERSION files.
Had to bump COLLECTOR_VERSION to a successful Konflux build.

User-facing documentation

Testing and quality

  • [ ] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • [ ] added unit tests
  • [ ] added e2e tests
  • [ ] added regression tests
  • [ ] added compatibility tests
  • [ ] modified existing tests

How I validated my change

  • check-collector-images-exist
  • check-scanner-images-exist

checks on the build pipeline.

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Dec 3, 2024

Images are ready for the commit at b0c5ed0.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-233-gb0c5ed0373.

@tommartensen tommartensen marked this pull request as ready for review December 4, 2024 09:25
@tommartensen tommartensen requested a review from a team as a code owner December 4, 2024 09:25
@tommartensen tommartensen changed the title ROX-27203: Ensure collector/scanner images exist during periodic updates ROX-27203: Ensure collector/scanner images exist during updates Dec 4, 2024
@tommartensen tommartensen requested a review from msugakov December 4, 2024 10:02
@github-actions github-actions bot added the ci-all-qa-tests Tells CI to run all API tests (not just BAT). label Dec 6, 2024
@tommartensen tommartensen added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Dec 6, 2024
@tommartensen tommartensen requested review from msugakov and removed request for a team December 6, 2024 14:13
@tommartensen
Copy link
Contributor Author

/retest

Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I have some new thoughts

Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
@tommartensen tommartensen enabled auto-merge (squash) December 10, 2024 10:34
@tommartensen tommartensen merged commit a21135e into master Dec 10, 2024
@tommartensen tommartensen deleted the tm/ROX-27203-wait-for-collector-images branch December 10, 2024 12:01
parametalol pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Conflicts:
	COLLECTOR_VERSION
msugakov added a commit that referenced this pull request Jun 25, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Conflicts:
	COLLECTOR_VERSION
msugakov added a commit that referenced this pull request Jun 25, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Conflicts:
	COLLECTOR_VERSION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 ci-all-qa-tests Tells CI to run all API tests (not just BAT).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants