ROX-28879: Update ScannerV2&Collector Konflux image checks#14827
ROX-28879: Update ScannerV2&Collector Konflux image checks#14827
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at f0b706b. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14827 +/- ##
==========================================
+ Coverage 48.87% 48.95% +0.08%
==========================================
Files 2547 2550 +3
Lines 186906 187222 +316
==========================================
+ Hits 91347 91662 +315
+ Misses 88323 88308 -15
- Partials 7236 7252 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
because it actually does not. This is to help with the situation when check-* jobs block the release. See https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1743438459477049?thread_ts=1742820121.886399&cid=C05TS9N0S7L
While "style" is not a perfect word for it, I see it a better place for such checks in the spirit of ensuring consistency of the code. Only used cut and paste, no other manual changes.
I don't see a reason why not have us notified when either of these jobs fails.
0c419f3 to
af62da7
Compare
|
@msugakov: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Deleted former |
|
Hah. Unlucky timing. #14892 got auto-merged and now the checks aren't succeeding for |
|
I am working this around by doing the following $ podman pull quay.io/rhacs-eng/scanner:2.36.x-31-g08a8cf1925-fast
$ podman tag quay.io/rhacs-eng/scanner:2.36.x-31-g08a8cf1925-fast quay.io/rhacs-eng/scanner:2.36.x-33-g26c2c627bd-fast
$ podman push quay.io/rhacs-eng/scanner:2.36.x-33-g26c2c627bd-fast
$ podman pull quay.io/rhacs-eng/scanner-db-slim:2.36.x-31-g08a8cf1925-fast
$ podman tag quay.io/rhacs-eng/scanner-db-slim:2.36.x-31-g08a8cf1925-fast quay.io/rhacs-eng/scanner-db-slim:2.36.x-33-g26c2c627bd-fast
$ podman push quay.io/rhacs-eng/scanner-db-slim:2.36.x-33-g26c2c627bd-fastI know it's not good but I'm sure we'll have more SCANNER_VERSION updates before we get near to be releasing with Konflux. |
|
Made these checks required for |
Conflicts: .github/workflows/build.yaml
To the same effect as `git cherry-pick 7ea6887`. Did not add `collector-slim` to the check list because there's no GHA built image `quay.io/rhacs-eng/collector-slim:<original-collector-version>` and there's no Konflux build image `quay.io/rhacs-eng/release-collector-slim:<original-collector-version>`
Description
This follows up on #13502 in the light that some parts of the approach block the release as evidenced in https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1743438459477049?thread_ts=1742820121.886399&cid=C05TS9N0S7L.
There's also a discussion in https://github.com/stackrox/stackrox/pull/14825/files#r2022395918 (for the context).
This change can be reviewed by commits which I provided with descriptions.
The future plans are:
masterto respect the new place of the jobs.User-facing documentation
Testing and quality
Automated testing
No change.
How I validated my change
Just looking at CI.