ROX-23316: check: confirm all components are part of snapshot#13748
Merged
tommartensen merged 7 commits intomasterfrom Jan 13, 2025
Merged
ROX-23316: check: confirm all components are part of snapshot#13748tommartensen merged 7 commits intomasterfrom
tommartensen merged 7 commits intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 19f5316. To use with deploy scripts, first |
14 tasks
msugakov
reviewed
Jan 8, 2025
Contributor
Author
|
/retest |
msugakov
reviewed
Jan 9, 2025
msugakov
approved these changes
Jan 10, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
|
@tommartensen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ajheflin
pushed a commit
that referenced
this pull request
Jun 24, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
msugakov
added a commit
that referenced
this pull request
Jun 25, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
msugakov
added a commit
that referenced
this pull request
Jun 25, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up from #13577.
I renamed the
wait-for-collector-imagetask to keep it in sync with the component name.Discussion point:
RELATED_IMAGE_COLLECTOR_FULL- should it be renamed toRELATED_IMAGE_COLLECTOR?User-facing documentation
Testing and quality
Automated testing
How I validated my change
Running the check script locally with invalid changes to the operator-bundle-pipeline, e.g. commenting out
wait-for-...-image. Also https://github.com/stackrox/stackrox/actions/runs/12671318977/job/35312817486?pr=13748#step:10:39.operator-bundle-on-pushpipeline starts, so I assume that the renaming was successful.