Skip to content

ROX-27612: Removes Collector slim references from tekton pipeline#14169

Merged
Stringy merged 3 commits intomasterfrom
giles/ROX-27612-remove-collector-slim-component
Feb 10, 2025
Merged

ROX-27612: Removes Collector slim references from tekton pipeline#14169
Stringy merged 3 commits intomasterfrom
giles/ROX-27612-remove-collector-slim-component

Conversation

@Stringy
Copy link
Contributor

@Stringy Stringy commented Feb 7, 2025

Description

Following #13350, this removes references to Collector slim, and adjusts RELATED_IMAGE_COLLECTOR_FULL to RELATED_IMAGE_COLLECTOR as per discussions on #13748

User-facing documentation

- [ ] CHANGELOG is updated OR update is not needed
- [ ] documentation PR is created and is linked above OR is not needed

Testing and quality

Relying on CI

@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Stringy Stringy added the konflux-build Run Konflux in PR. Push commit to trigger it. label Feb 7, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 7, 2025

Images are ready for the commit at 1c4585d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-669-g1c4585d734.

@Stringy Stringy marked this pull request as ready for review February 7, 2025 14:33
@Stringy Stringy requested a review from a team as a code owner February 7, 2025 14:33
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.96%. Comparing base (aeb66e6) to head (1c4585d).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14169      +/-   ##
==========================================
+ Coverage   48.93%   48.96%   +0.03%     
==========================================
  Files        2505     2505              
  Lines      181612   181602      -10     
==========================================
+ Hits        88866    88920      +54     
+ Misses      85692    85638      -54     
+ Partials     7054     7044      -10     
Flag Coverage Δ
go-unit-tests 48.96% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stringy Stringy requested a review from a team as a code owner February 7, 2025 16:01
@Stringy Stringy requested review from porridge and removed request for a team February 7, 2025 16:01
@tommartensen tommartensen added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Feb 10, 2025
Copy link
Contributor

@tommartensen tommartensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all Konflux pipelines are green!

@tommartensen tommartensen removed the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Feb 10, 2025
@tommartensen
Copy link
Contributor

tommartensen commented Feb 10, 2025

This shouldn't be backported to 4.6 build on Konflux, it's a 4.7+ change. (no action required, just a reminder not to add the backport label)

@Stringy Stringy enabled auto-merge (squash) February 10, 2025 13:22
@Stringy Stringy merged commit d672838 into master Feb 10, 2025
109 of 116 checks passed
@Stringy Stringy deleted the giles/ROX-27612-remove-collector-slim-component branch February 10, 2025 14:06
shireenf-ibm pushed a commit to shireenf-ibm/stackrox that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/operator konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants