Skip to content

WIP: Use walk by query instead of get many#14216

Closed
janisz wants to merge 2 commits intomasterfrom
use_walk_by_query_instead_of_get_many
Closed

WIP: Use walk by query instead of get many#14216
janisz wants to merge 2 commits intomasterfrom
use_walk_by_query_instead_of_get_many

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Feb 11, 2025

Description

                                          │   old.txt   │               new.txt               │
                                          │   sec/op    │    sec/op     vs base               │
AlertDatabaseOps/searchWithRawListAlert-8   9.999m ± 1%   9.430m ± 10%  -5.69% (p=0.029 n=10)

                                          │   old.txt    │               new.txt               │
                                          │     B/op     │     B/op      vs base               │
AlertDatabaseOps/searchWithRawListAlert-8   8.366Mi ± 0%   8.320Mi ± 0%  -0.55% (p=0.000 n=10)

                                          │   old.txt   │              new.txt               │
                                          │  allocs/op  │  allocs/op   vs base               │
AlertDatabaseOps/searchWithRawListAlert-8   111.2k ± 0%   109.2k ± 0%  -1.80% (p=0.000 n=10)

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@janisz
pg(pref): use walk by query instead of get many
b6bb402 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
fix
c5a1d96 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from a team as a code owner February 11, 2025 16:07
@janisz janisz marked this pull request as draft February 11, 2025 16:07
@janisz janisz removed the request for review from a team February 11, 2025 16:07
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 11, 2025

Images are ready for the commit at c5a1d96.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-709-gc5a1d96219.

@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2025

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-operator-e2e-tests c5a1d96 link false /test ocp-4-12-operator-e2e-tests
ci/prow/gke-nongroovy-e2e-tests c5a1d96 link true /test gke-nongroovy-e2e-tests
ci/prow/gke-upgrade-tests c5a1d96 link false /test gke-upgrade-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests c5a1d96 link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/gke-qa-e2e-tests c5a1d96 link false /test gke-qa-e2e-tests
ci/prow/ocp-4-17-nongroovy-e2e-tests c5a1d96 link false /test ocp-4-17-nongroovy-e2e-tests
ci/prow/ocp-4-17-qa-e2e-tests c5a1d96 link false /test ocp-4-17-qa-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests c5a1d96 link false /test ocp-4-12-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz janisz changed the title Use walk by query instead of get many WIP: Use walk by query instead of get many Feb 13, 2025
@janisz janisz mentioned this pull request Feb 13, 2025
Merged
5 tasks
@janisz janisz closed this Apr 4, 2025
@janisz janisz deleted the use_walk_by_query_instead_of_get_many branch April 4, 2025 12:05
@janisz janisz mentioned this pull request Apr 16, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/central area/postgres do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janisz @rhacs-bot