Skip to content

perf(k6): add simple grpc test#14265

Merged
janisz merged 8 commits intomasterfrom
add_k6_grpc_tests
Mar 12, 2025
Merged

perf(k6): add simple grpc test#14265
janisz merged 8 commits intomasterfrom
add_k6_grpc_tests

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Feb 13, 2025

Description

This PR adds a simple k6 grpc test that will list alerts.
It will be used for E2E testing of:

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

@janisz janisz requested a review from a team as a code owner February 13, 2025 13:41
@janisz janisz requested review from JoukoVirtanen, mtodor and rhybrillou and removed request for a team February 13, 2025 13:41
@rhybrillou rhybrillou added the ci-performance-tests Runs the K6 based performance tests label Feb 13, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 13, 2025 •
edited
Loading

Images are ready for the commit at 0ff29f3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-196-g0ff29f36d1.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Performance test results

Summary

  █ main dashboard

  █ list alerts grpc

    ✓ status is OK

  checks.........................: 100.00% ✓ 50        ✗ 0  
  data_received..................: 3.9 MB  130 kB/s
  data_sent......................: 240 kB  7.9 kB/s
  group_duration.................: avg=253.24ms min=72.73ms med=245.54ms max=658.48ms p(90)=437.5ms  p(95)=444.83ms
  grpc_req_duration..............: avg=73.1ms   min=71.43ms med=72.82ms  max=76.01ms  p(90)=74.47ms  p(95)=75.07ms 
  http_req_blocked...............: avg=153.02µs min=290ns   med=401ns    max=68.66ms  p(90)=592ns    p(95)=696ns   
  http_req_connecting............: avg=74.01µs  min=0s      med=0s       max=33.3ms   p(90)=0s       p(95)=0s      
  http_req_duration..............: avg=47.68ms  min=33.3ms  med=38.69ms  max=143.73ms p(90)=96.23ms  p(95)=104.22ms
    { expected_response:true }...: avg=51.67ms  min=37.1ms  med=39.85ms  max=143.73ms p(90)=99.78ms  p(95)=108.22ms
  ✓ { lib:true }.................: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
  http_req_failed................: 22.22%  ✓ 100       ✗ 350
  http_req_receiving.............: avg=237.93µs min=22.57µs med=41.11µs  max=65.77ms  p(90)=283.03µs p(95)=373.75µs
  http_req_sending...............: avg=66.9µs   min=36.62µs med=67.03µs  max=188.13µs p(90)=81.3µs   p(95)=91.32µs 
  http_req_tls_handshaking.......: avg=78.25µs  min=0s      med=0s       max=35.21ms  p(90)=0s       p(95)=0s      
  http_req_waiting...............: avg=47.38ms  min=33.22ms med=38.55ms  max=143.55ms p(90)=96.02ms  p(95)=103.93ms
  http_reqs......................: 450     14.835345/s
  iteration_duration.............: avg=606.64ms min=587.7ms med=600.32ms max=832.98ms p(90)=618.32ms p(95)=628.92ms
  iterations.....................: 50      1.648372/s
  vus............................: 1       min=1       max=1
  vus_max........................: 1       min=1       max=1

Sources

rhybrillou
rhybrillou reviewed Feb 13, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.19%. Comparing base (7e23be6) to head (0ff29f3).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #14265       +/-   ##
===========================================
- Coverage   49.45%   49.19%    -0.27%     
===========================================
  Files         723     2526     +1803     
  Lines       72094   184588   +112494     
===========================================
+ Hits        35655    90802    +55147     
- Misses      33198    86575    +53377     
- Partials     3241     7211     +3970
Flag Coverage Δ
go-unit-tests 49.19% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoukoVirtanen
JoukoVirtanen reviewed Feb 13, 2025
View reviewed changes
JoukoVirtanen
JoukoVirtanen reviewed Feb 13, 2025
View reviewed changes
@JoukoVirtanen
Copy link
Contributor

JoukoVirtanen commented Feb 13, 2025

I noticed that there are some failures

http_req_failed................: 8.33%  ✓ 100      ✗ 1100

mtodor
mtodor reviewed Feb 17, 2025
View reviewed changes
@janisz janisz mentioned this pull request Feb 17, 2025
Merged
5 tasks
@janisz janisz requested a review from mtodor February 17, 2025 16:25
mtodor
mtodor reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@mtodor mtodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Let's just run the CI pipeline once to see how results look like and if everything is ok with tags.

janisz added 8 commits March 10, 2025 10:15
@janisz
perf(k6): add simple grpc test
0538c7e 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
fixes
038dc77 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
fixes
b63f1b3 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
add fetched alerts count to tags
6ef7315 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
use symlink instead of ../../../
3d7c399 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
clone tags and pass limit
4380e44 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
fix
be9b851 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
fixes
0ff29f3 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the add_k6_grpc_tests branch from d584886 to 0ff29f3 Compare March 10, 2025 09:47
@janisz janisz requested a review from a team as a code owner March 10, 2025 09:47
@janisz janisz requested a review from mtodor March 10, 2025 09:48
@janisz
Copy link
Contributor Author

janisz commented Mar 10, 2025

@mtodor @JoukoVirtanen @rhybrillou PTAL

mtodor
mtodor approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@mtodor mtodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tnx @janisz!

There are some failures, but that is not related to this PR.
Also JS styles are mixed. For that, we should add styles check in CI.

@janisz janisz enabled auto-merge (squash) March 12, 2025 11:53
@janisz janisz merged commit 1bcdfad into master Mar 12, 2025
91 checks passed
@janisz janisz deleted the add_k6_grpc_tests branch March 12, 2025 13:01
@janisz janisz mentioned this pull request Mar 20, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtodor mtodor mtodor approved these changes

@JoukoVirtanen JoukoVirtanen Awaiting requested review from JoukoVirtanen

@rhybrillou rhybrillou Awaiting requested review from rhybrillou

Assignees

No one assigned

Labels

ci-performance-tests Runs the K6 based performance tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@janisz @rhacs-bot @JoukoVirtanen @mtodor @rhybrillou