Skip to content

ROX-27053: Fix subjects handling for user and group kind [backport] #14348

Merged
davdhacs merged 1 commit intorelease-4.6from
backport-13410-to-release-4.6
Feb 25, 2025
Merged

ROX-27053: Fix subjects handling for user and group kind [backport] #14348
davdhacs merged 1 commit intorelease-4.6from
backport-13410-to-release-4.6

Conversation

@rhacs-bot
Copy link
Contributor

@rhacs-bot rhacs-bot commented Feb 19, 2025

Backport 367a7ff from #13410.

I am hoping this fixes release-4.6-gke-qa-e2e-tests repeatedly failing on another backport pr: #13866 (comment)

@github-actions github-actions bot added area/central backport PR to backport changes from master to release branch labels Feb 19, 2025
@davdhacs davdhacs changed the title [Backport release-4.6] ROX-27053: Fix subjects handling for user and group kind ROX-27053: Fix subjects handling for user and group kind [Backport release-4.6] Feb 19, 2025
@davdhacs davdhacs enabled auto-merge (squash) February 19, 2025 21:39
@rhacs-bot
Copy link
Contributor Author

Images are ready for the commit at 8251971.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.2-1-g8251971181.

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.42%. Comparing base (ecff2a4) to head (8251971).
Report is 1 commits behind head on release-4.6.

Files with missing lines Patch % Lines
central/compliance/checks/common/rbac.go 0.00% 3 Missing ⚠️
pkg/k8srbac/subjects.go 88.23% 2 Missing ⚠️
central/rbac/service/get_subject.go 0.00% 1 Missing ⚠️
pkg/k8srbac/evaluator_impl.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-4.6   #14348      +/-   ##
===============================================
- Coverage        48.44%   48.42%   -0.02%     
===============================================
  Files             2468     2469       +1     
  Lines           178397   178501     +104     
===============================================
+ Hits             86422    86440      +18     
- Misses           85024    85110      +86     
  Partials          6951     6951              
Flag Coverage Δ
go-unit-tests 48.42% <72.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davdhacs davdhacs added the auto-retest PRs with this label will be automatically retested if prow checks fails label Feb 20, 2025
@davdhacs
Copy link
Contributor

/test ocp-4-12-compliance-e2e-tests

@davdhacs davdhacs requested a review from mtodor February 20, 2025 00:30
@davdhacs davdhacs requested a review from clickboo February 20, 2025 00:37
@davdhacs davdhacs changed the title ROX-27053: Fix subjects handling for user and group kind [Backport release-4.6] ROX-27053: Fix subjects handling for user and group kind [backport] Feb 20, 2025
@davdhacs davdhacs added this to the 4.6.3-rc.1 milestone Feb 20, 2025
@davdhacs davdhacs requested a review from janisz February 20, 2025 20:57
@davdhacs davdhacs merged commit e5405ab into release-4.6 Feb 25, 2025
90 of 102 checks passed
@davdhacs davdhacs deleted the backport-13410-to-release-4.6 branch February 25, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/central auto-retest PRs with this label will be automatically retested if prow checks fails backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants