Skip to content

ROX-13493: Add admission controller support for Scale subresource (#1…#14349

Merged
janisz merged 1 commit intorelease-4.6from
backport-14296-to-release-4.6
Feb 27, 2025
Merged

ROX-13493: Add admission controller support for Scale subresource (#1…#14349
janisz merged 1 commit intorelease-4.6from
backport-14296-to-release-4.6

Conversation

@clickboo
Copy link
Contributor

…4296)

(cherry picked from commit 9f548f9)

Description

change me!

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@clickboo clickboo requested a review from a team as a code owner February 20, 2025 00:29
@github-actions github-actions bot added area/sensor area/admission-controller backport PR to backport changes from master to release branch labels Feb 20, 2025
@davdhacs
Copy link
Contributor

This other PR may be needed to fix the gke-qa-e2e tests that are repeatedly failing on release-4.6: #14348

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 20, 2025

Images are ready for the commit at 75c0a2d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.3-rc.1-1-g75c0a2d34f.

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.42%. Comparing base (fbac7a6) to head (75c0a2d).
Report is 1 commits behind head on release-4.6.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-4.6   #14349   +/-   ##
============================================
  Coverage        48.42%   48.42%           
============================================
  Files             2469     2469           
  Lines           178501   178501           
============================================
+ Hits             86442    86448    +6     
+ Misses           85107    85104    -3     
+ Partials          6952     6949    -3     
Flag Coverage Δ
go-unit-tests 48.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjwilson vjwilson added backport release-4.5 backport release-4.6 Create a PR to backport this PR to release-4.6 and removed backport release-4.5 backport release-4.6 Create a PR to backport this PR to release-4.6 labels Feb 24, 2025
@janisz janisz force-pushed the backport-14296-to-release-4.6 branch from b6beb24 to 75c0a2d Compare February 26, 2025 11:33
@janisz janisz requested a review from dashrews78 February 26, 2025 11:36
@janisz
Copy link
Contributor

janisz commented Feb 26, 2025

/retest

@janisz janisz merged commit 39432a6 into release-4.6 Feb 27, 2025
73 of 84 checks passed
@janisz janisz deleted the backport-14296-to-release-4.6 branch February 27, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admission-controller area/sensor backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants