fix(proto): symlink protos instead of copy#14690
Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
parametalol
reviewed
Mar 20, 2025
parametalol
approved these changes
Mar 20, 2025
Contributor
|
Images are ready for the commit at 3985ede. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14690 +/- ##
==========================================
+ Coverage 49.18% 49.19% +0.01%
==========================================
Files 2532 2533 +1
Lines 185523 185512 -11
==========================================
+ Hits 91246 91265 +19
+ Misses 87050 87025 -25
+ Partials 7227 7222 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We used to copy and transform protos before using them in QA tests. This PR removes copying and uses symlinks instead. This will improve developer flow as changes in protos will not require calling
make proto-generated-srcs -C symling_protos_for_java.Previously I failed to add relative symlink but we already have one in k6 tests so let's use it here too.
Refs:
Testing
Automated testing
How I validated my change
CI