Skip to content

Merge PLOP enrichment with endpoint enrichment#14880

Closed
vikin91 wants to merge 1 commit intopiotr/ROX-28259-the-sensor-fixfrom
piotr/refactor-plop-enrichment
Closed

Merge PLOP enrichment with endpoint enrichment#14880
vikin91 wants to merge 1 commit intopiotr/ROX-28259-the-sensor-fixfrom
piotr/refactor-plop-enrichment

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Apr 4, 2025

Merge PLOP enrichment with endpoint enrichment

Refactor PLOP enrichment

Description

change me!

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@vikin91
Copy link
Contributor Author

vikin91 commented Apr 4, 2025

@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Apr 4, 2025

Images are ready for the commit at 0c3a6e5.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-437-g0c3a6e5922.

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.96%. Comparing base (27bd009) to head (0c3a6e5).
Report is 28 commits behind head on piotr/ROX-28259-the-sensor-fix.

Files with missing lines Patch % Lines
sensor/common/networkflow/manager/manager_impl.go 75.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           piotr/ROX-28259-the-sensor-fix   #14880      +/-   ##
==================================================================
- Coverage                           48.97%   48.96%   -0.02%     
==================================================================
  Files                                2551     2551              
  Lines                              187472   187447      -25     
==================================================================
- Hits                                91814    91779      -35     
- Misses                              88400    88406       +6     
- Partials                             7258     7262       +4     
Flag Coverage Δ
go-unit-tests 48.96% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91 vikin91 force-pushed the piotr/ROX-28259-the-sensor-fix branch from 6ab33a6 to 633ea1a Compare April 7, 2025 13:00
@vikin91 vikin91 force-pushed the piotr/refactor-plop-enrichment branch from 6d29f8b to 18ffcd8 Compare April 7, 2025 13:00
@vikin91 vikin91 force-pushed the piotr/ROX-28259-the-sensor-fix branch from 633ea1a to cbc809c Compare April 7, 2025 13:22
@vikin91 vikin91 force-pushed the piotr/refactor-plop-enrichment branch from 18ffcd8 to 8c464f3 Compare April 7, 2025 13:23
@vikin91 vikin91 mentioned this pull request Apr 7, 2025
10 tasks
@vikin91 vikin91 force-pushed the piotr/ROX-28259-the-sensor-fix branch from 9aba1ec to 2f5c078 Compare April 7, 2025 15:22
@vikin91 vikin91 force-pushed the piotr/refactor-plop-enrichment branch from 8c464f3 to eedbb5c Compare April 7, 2025 15:23
@vikin91 vikin91 force-pushed the piotr/ROX-28259-the-sensor-fix branch from 2f5c078 to e609c7d Compare April 8, 2025 12:10
@vikin91 vikin91 force-pushed the piotr/refactor-plop-enrichment branch from eedbb5c to 2204e81 Compare April 8, 2025 12:10
@vikin91 vikin91 force-pushed the piotr/refactor-plop-enrichment branch from 2204e81 to 0c3a6e5 Compare April 9, 2025 10:05
@vikin91
Copy link
Contributor Author

vikin91 commented Apr 9, 2025

Will reopen this activity later with a new set of ideas

@vikin91 vikin91 closed this Apr 9, 2025
@vikin91 vikin91 deleted the piotr/refactor-plop-enrichment branch September 10, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants