Skip to content

ROX-28859: Upgrade Grafana to v10#14901

Merged
vikin91 merged 1 commit intomasterfrom
piotr/upgrade-grafana
Apr 8, 2025
Merged

ROX-28859: Upgrade Grafana to v10#14901
vikin91 merged 1 commit intomasterfrom
piotr/upgrade-grafana

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Apr 7, 2025 •
edited
Loading

Upgrade Grafana to 10.4.17

Description

Grafana 7 has a nasty bug that makes it impossible to edit the dashboards in modern browser: when trying to edit the promQL query, random characters appear in the edit field and one cannot type (only copy-pasting works).

Blocks #14899

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
    • THIS IS NOT A PRODUCTION CHANGE! It only affects our developer-monitoring stack.
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • Deployed it locally and checked the logs to see no errors. Logged in and explored the dashboards (creating new visualizations, editing, browsing metrics etc).
  • I didn't check the alarms used for long-running clusters - lt looks like this part is handled in prom alertmanager.

@vikin91
Copy link
Contributor Author

vikin91 commented Apr 7, 2025 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@vikin91 vikin91 force-pushed the piotr/upgrade-grafana branch from b382903 to 4b72409 Compare April 7, 2025 13:19
@vikin91 vikin91 changed the base branch from piotr/ROX-28259-the-sensor-fix to master April 7, 2025 13:22
@vikin91 vikin91 force-pushed the piotr/upgrade-grafana branch from 4b72409 to bfec36a Compare April 7, 2025 13:22
This was referenced Apr 7, 2025
Closed
Closed
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Apr 7, 2025 •
edited
Loading

Images are ready for the commit at e7b173b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-411-ge7b173b011.

@codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (2eeffbb) to head (e7b173b).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #14901      +/-   ##
==========================================
- Coverage   49.01%   49.01%   -0.01%     
==========================================
  Files        2546     2546              
  Lines      186966   186966              
==========================================
- Hits        91641    91639       -2     
- Misses      88076    88077       +1     
- Partials     7249     7250       +1
Flag Coverage Δ
go-unit-tests 49.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Apr 7, 2025
Merged
Merged
@vikin91 vikin91 requested review from a team and stehessel April 7, 2025 15:19
@vikin91 vikin91 force-pushed the piotr/upgrade-grafana branch from bfec36a to e7b173b Compare April 7, 2025 15:22
@vikin91 vikin91 changed the title ROX-28259: Upgrade Grafana to v10 ROX-28859: Upgrade Grafana to v10 Apr 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2025

@vikin91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-18-scanner-v4-install-tests e7b173b link false /test ocp-4-18-scanner-v4-install-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

stehessel
stehessel reviewed Apr 7, 2025
View reviewed changes
stehessel
stehessel approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@stehessel stehessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would bump it to latest version, but I guess I'm greedy 😅

@vikin91
Copy link
Contributor Author

vikin91 commented Apr 8, 2025

I would bump it to latest version, but I guess I'm greedy 😅

Let's do it step-by-step if that is okay. I can volunteer to check the newest version and also bump prom and alertmanager, but I would like to do it a bit later.

@vikin91 vikin91 merged commit af2f4e3 into master Apr 8, 2025
98 of 99 checks passed
@vikin91 vikin91 deleted the piotr/upgrade-grafana branch April 8, 2025 09:08
daynewlee pushed a commit that referenced this pull request Apr 8, 2025
@vikin91 @daynewlee
ROX-28859: Upgrade Grafana to v10 (#14901)
3032196
@vikin91 vikin91 mentioned this pull request Apr 24, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stehessel stehessel stehessel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vikin91 @rhacs-bot @stehessel