ROX-14475: Upgrade to UBI9 - postgres rpm download#15337
ROX-14475: Upgrade to UBI9 - postgres rpm download#15337
Conversation
|
/test gke-qa-e2e-tests |
There was a problem hiding this comment.
Hey @davdhacs - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at e2ebc0c. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15337 +/- ##
=======================================
Coverage 49.25% 49.26%
=======================================
Files 2581 2581
Lines 189350 189350
=======================================
+ Hits 93261 93277 +16
+ Misses 88746 88732 -14
+ Partials 7343 7341 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
looking at one of the tests, https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stackrox_stackrox/15337/pull-ci-stackrox-stackrox-master-ocp-4-18-qa-e2e-tests/1923844275313840128
so, it looks like something with updating ca's is being blocked. Maybe the owner changed in the base image (not sure if we're using a different uid) or there is an additional step required on rhel9 for an update |
|
I don't pretend to understand why we're messing around with |
Maybe it is a system service that is running or triggered somehow; I do not know if we're running anything outside our entrypoint |
|
We are replacing these files in the https://github.com/stackrox/stackrox/blob/master/image/rhel/static-bin/central-entrypoint.sh#L25 |
|
/test gke-qa-e2e-tests |
|
/test gke-qa-e2e-tests |
|
I was wrong. The file perms error is earlier (https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/stackrox_stackrox/15337/pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests/1924872987819905024/artifacts/gke-qa-e2e-tests/stackrox-stackrox-e2e-test/artifacts/central-74d7c79ff5-5kkm4-central-previous.log): |
|
/test gke-nongroovy-e2e-tests |
|
An example of a failed overwrite file I think the cp should still pass because of the |
|
summary of what I understand of the file-perms failure in central startup:
Problem: |
|
/test gke-qa-e2e-tests |
|
@davdhacs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
to test #15335