Conversation
|
Skipping CI for Draft Pull Request. |
|
/test gke-qa-e2e-tests |
There was a problem hiding this comment.
Hey @davdhacs - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at 76441bf. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15421 +/- ##
==========================================
- Coverage 49.21% 49.21% -0.01%
==========================================
Files 2577 2577
Lines 189093 189093
==========================================
- Hits 93065 93058 -7
- Misses 88691 88695 +4
- Partials 7337 7340 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test gke-qa-e2e-tests |
|
@davdhacs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
testing comparison with ubi-9 base image for update-ca file permissions in #15337