ROX-20689: Use authorizer pattern in /v1/ping#15430
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
5f3588d to
fdd4da8
Compare
Contributor
|
Images are ready for the commit at fdd4da8. To use with deploy scripts, first |
Contributor
|
Images are ready for the commit at fdd4da8. To use with deploy scripts, first |
rhybrillou
approved these changes
May 26, 2025
Contributor
Author
|
/test all |
Contributor
Author
|
/retest |
Contributor
There was a problem hiding this comment.
Hey @guzalv - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
9 tasks
vikin91
pushed a commit
that referenced
this pull request
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The service code was not consistent with the authorizer pattern used for other service layers, this PR fixes this.
User-facing documentation
Testing and quality
Automated testing
Unit tests don't exist for ping.
How I validated my change
CI, manual testing.