ROX-20689: Document why /v1/ping can remain public#15431
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
4 tasks
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at c85a574. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15431 +/- ##
=======================================
Coverage 49.24% 49.24%
=======================================
Files 2578 2578
Lines 189155 189155
=======================================
+ Hits 93145 93150 +5
+ Misses 88678 88674 -4
+ Partials 7332 7331 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhybrillou
approved these changes
May 26, 2025
vikin91
pushed a commit
that referenced
this pull request
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document why /v1/ping can remain public by adding a comment in the service code. Text copied and adapted from
https://issues.redhat.com/browse/ROX-20689