Skip to content

ROX-29453: Inactive image retention setting 0 should never prune images#15470

Merged
sachaudh merged 1 commit intorelease-4.6from
backport-15444-to-release-4.6
May 29, 2025
Merged

ROX-29453: Inactive image retention setting 0 should never prune images#15470
sachaudh merged 1 commit intorelease-4.6from
backport-15444-to-release-4.6

Conversation

@rhacs-bot
Copy link
Contributor

@rhacs-bot rhacs-bot commented May 28, 2025

Backport 62b9857 from #15444.

@github-actions github-actions bot added area/central backport PR to backport changes from master to release branch labels May 28, 2025
@rhacs-bot
Copy link
Contributor Author

rhacs-bot commented May 28, 2025

Images are ready for the commit at a5db910.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.6-1-ga5db910835.

@codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.43%. Comparing base (008842b) to head (a5db910).

Files with missing lines Patch % Lines
central/pruning/pruning.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-4.6   #15470      +/-   ##
===============================================
- Coverage        48.43%   48.43%   -0.01%     
===============================================
  Files             2470     2470              
  Lines           178524   178528       +4     
===============================================
  Hits             86469    86469              
- Misses           85105    85108       +3     
- Partials          6950     6951       +1
Flag Coverage Δ
go-unit-tests 48.43% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sachaudh
Copy link
Contributor

sachaudh commented May 28, 2025

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 29, 2025

@rhacs-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests a5db910 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sachaudh sachaudh merged commit 27cf97b into release-4.6 May 29, 2025
74 of 86 checks passed
@sachaudh sachaudh deleted the backport-15444-to-release-4.6 branch May 29, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachaudh sachaudh sachaudh approved these changes

Assignees

No one assigned

Labels

area/central backport PR to backport changes from master to release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhacs-bot @sachaudh @charmik-redhat