ROX-29453: Inactive image retention setting 0 should never prune images#15444
Conversation
There was a problem hiding this comment.
Hey @charmik-redhat - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at 2047f3e. To use with deploy scripts, first |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15444 +/- ##
==========================================
- Coverage 49.23% 49.23% -0.01%
==========================================
Files 2578 2578
Lines 189182 189186 +4
==========================================
- Hits 93151 93145 -6
- Misses 88693 88701 +8
- Partials 7338 7340 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@charmik-redhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
For inactive images retention value of 0, the expectation is that the inactive images will never be pruned. However there is a bug in pruning logic which causes the inactive images to get instantly pruned every hour when the retention value is 0. This could lead to frequent resetting of the firstDiscovered and firstImageOccurrence times of the CVEs in images that are only temporarily inactive.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Manual test- pending