Skip to content

chore(deps): update docker config#15549

Merged
janisz merged 4 commits intomasterfrom
update_docker_config
Jul 4, 2025
Merged

chore(deps): update docker config#15549
janisz merged 4 commits intomasterfrom
update_docker_config

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Jun 3, 2025

This PR updates docker config definition with k8s changes and tests.

See:

@janisz janisz requested a review from RTann June 3, 2025 12:10
@janisz janisz changed the title deps(docker): update docker config chore(deps): update docker config Jun 3, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @janisz - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

RTann
RTann reviewed Jun 4, 2025
View reviewed changes
Copy link
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious the purpose of these changes. Did something start failing?

@janisz
Copy link
Contributor Author

janisz commented Jun 4, 2025

It's related to #15270 and I discovered that we could have issues with non padded base64. So far there were no reported issues but I think it's good to update anyway.

@vikin91
Copy link
Contributor

vikin91 commented Jun 5, 2025

Could you test that using the base64 data from those tests? https://github.com/stackrox/stackrox/pull/15270/files#diff-d037284920ac19198466df83d9909c321510421921b05971c705e1506b1f1c5fR462-R481

It would tell us whether we were really incorrectly decoding base64 in that particular case.

@janisz
Copy link
Contributor Author

janisz commented Jun 10, 2025

@vikin91 kubernetes/kubernetes#132104

RTann
RTann approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

janisz added 2 commits June 23, 2025 13:06
@janisz
deps(docker): update docker config
cd982b4 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
remove headers
8fba8a6 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the update_docker_config branch from 509ead5 to 8fba8a6 Compare June 23, 2025 11:18
@codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.80%. Comparing base (7b77295) to head (d0431cc).
Report is 29 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #15549    +/-   ##
========================================
  Coverage   48.80%   48.80%            
========================================
  Files        2590     2592     +2     
  Lines      190528   190658   +130     
========================================
+ Hits        92990    93060    +70     
- Misses      90235    90293    +58     
- Partials     7303     7305     +2
Flag Coverage Δ
go-unit-tests 48.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz
Copy link
Contributor Author

janisz commented Jun 23, 2025

bugbot run

@janisz
fix
bad72a3 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jun 23, 2025 •
edited
Loading

Images are ready for the commit at d0431cc.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-110-gd0431cca16.

@janisz
fix style
d0431cc 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2025

@janisz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-18-qa-e2e-tests d0431cc link false /test ocp-4-18-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz janisz merged commit 7a3c2a3 into master Jul 4, 2025
92 of 93 checks passed
@janisz janisz deleted the update_docker_config branch July 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

+1 more reviewer

@RTann RTann RTann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janisz @vikin91 @rhacs-bot @RTann