ROX-8401, ROX-8465: Store internal registries + credentials#416
Merged
ROX-8401, ROX-8465: Store internal registries + credentials#416
Conversation
|
Tag for build #192529 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.68.x-204-g2501cef536'📦 You can also generate an installation bundle with: docker run -i --rm stackrox/main:3.68.x-204-g2501cef536 central generate interactive > bundle.zip🕹️ A |
RTann
commented
Feb 4, 2022
RTann
commented
Feb 4, 2022
connorgorman
reviewed
Feb 4, 2022
connorgorman
approved these changes
Feb 4, 2022
misberner
suggested changes
Feb 7, 2022
pkg/docker/types/config.go
Outdated
| @@ -0,0 +1,84 @@ | |||
| package types | |||
Contributor
There was a problem hiding this comment.
I'm not sure if this is the right package. pkg/docker/types AFAIK only contains types copied over from the Docker client library, to allow us to remove irrelevant fields and add easyjson support. The DockerConfigJSON type however is homegrown and doesn't exist in the docker library.
misberner
approved these changes
Feb 8, 2022
RTann
commented
Feb 8, 2022
connorgorman
reviewed
Feb 8, 2022
connorgorman
approved these changes
Feb 8, 2022
RTann
added a commit
that referenced
this pull request
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First part in resolving ROX-8401. In this PR, Sensor stores the credentials for the internal registries by using each namespace's default service account's dockercfg.
This does not touch the Autogenerated Registries, but I can remove them here, if desired.
Checklist
[ ] Evaluated and added CHANGELOG entry if required[ ] Determined and documented upgrade stepsTesting Performed
CI and manual tests in OpenShift 3.11 and OpenShift 4.7 environments.
The manual tests ensured we properly find and store the credentials for OpenShift internal registries.
To reproduce this:
ROX_LOCAL_IMAGE_SCANNINGis enabled in Sensor. Also, setLOGLEVEL=debugin Sensor to see debug logsUpserted registry "something" into the store